Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: libraries PGO assert during Find Loops #69032

Closed
AndyAyersMS opened this issue May 8, 2022 · 1 comment · Fixed by #69067
Closed

JIT: libraries PGO assert during Find Loops #69032

AndyAyersMS opened this issue May 8, 2022 · 1 comment · Fixed by #69067
Assignees
@AndyAyersMS
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
7.0.0

Comments

@AndyAyersMS
Copy link
Member

AndyAyersMS commented May 8, 2022 •
edited
Loading

Many libraries pgo tests now failing with

Assert failure(PID 5952 [0x00001740], Thread: 6833 [0x1ab1]): Assertion failed 'gtOper == GT_CNS_INT' in '<>c__DisplayClass35_0:<TestTryUpdate>b__1(System.Object):this' during 'Find loops' (IL size 171; hash 0x83ebfa29; Tier1-OSR)

    File: /__w/1/s/src/coreclr/jit/gentree.h Line: 2123
    Image: /datadisks/disk1/work/9E9D08F3/p/dotnet

across various options and architectures.

See
https://dev.azure.com/dnceng/public/_build/results?buildId=1758094&view=ms.vss-test-web.build-test-results-tab

Spot checking all the failures seem to be in Tier1-OSR compiles, so likely this is from #68725.

Similar asserts in the jit-experimental tests: https://dev.azure.com/dnceng/public/_build/results?buildId=1758339&view=ms.vss-test-web.build-test-results-tab
@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 8, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed untriaged New issue has not been triaged by the area owner labels May 8, 2022
@ghost
Copy link

ghost commented May 8, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Many libraries pgo tests now failing with

Assert failure(PID 5952 [0x00001740], Thread: 6833 [0x1ab1]): Assertion failed 'gtOper == GT_CNS_INT' in '<>c__DisplayClass35_0:<TestTryUpdate>b__1(System.Object):this' during 'Find loops' (IL size 171; hash 0x83ebfa29; Tier1-OSR)

    File: /__w/1/s/src/coreclr/jit/gentree.h Line: 2123
    Image: /datadisks/disk1/work/9E9D08F3/p/dotnet

across various options and architectures.

See
https://dev.azure.com/dnceng/public/_build/results?buildId=1758094&view=ms.vss-test-web.build-test-results-tab

Spot checking all the failures seem to be in Tier1-OSR compiles, so likely this is from #68725.

Author: AndyAyersMS
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@AndyAyersMS AndyAyersMS self-assigned this May 8, 2022
@AndyAyersMS AndyAyersMS added this to the 7.0.0 milestone May 8, 2022
AndyAyersMS added a commit to AndyAyersMS/runtime that referenced this issue May 9, 2022
@AndyAyersMS
JIT: fix issue with assert seen in OSR+PGO tests
13f7361 
`IsIconHandle` only works if we know the tree is an integer.

Closes dotnet#69032.
@AndyAyersMS AndyAyersMS mentioned this issue May 9, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 9, 2022
AndyAyersMS added a commit that referenced this issue May 11, 2022
@AndyAyersMS
JIT: fix issue with assert seen in OSR+PGO tests (#69067)
10a4986 
Update `IsIconHandle` to work for all tree types.

Closes #69032.
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 11, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AndyAyersMS AndyAyersMS

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

JIT: fix issue with assert seen in OSR+PGO tests AndyAyersMS/runtime
1 participant
@AndyAyersMS