-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship runtime using DllImportGenerator #60212
Comments
Can this be done by checking availability of the APIs required by the given marshaller? |
Yes, I believe we can design this such that each marshaller can validate that the APIs it uses are available. |
Remaining work for DllImportGenerator - including This is the drop in generated IL stubs on launch of some template applications after the use of DllImportGenerator in runtime libraries (most remaining stubs in the frameworks):
|
Issues to address after the initial merge (#59579):
out
/ref
and relying on source generation - make sure related functions have consistent argumentspartial extern
p/invokesGeneratedDllImport
for p/invokes in runtime with blittable signaturesGeneratedDllImport
DllImport
andGeneratedDllImport
and the need to think about which to use based on blittabilitypartial extern
p/invoke if target version is less than requiredDllImportGenerator
by default for all source projects instead of just NETCoreApp (closer to an in-box generator experience) and convert toGeneratedDllImport
CallingConvention
field onGeneratedDllImport
toUnmanagedCallConv
attribute #61134System.Memory
andSystem.Runtime.CompilerServices.Unsafe
for array marshallingRuntime issues discovered by DllImportGenerator
cc @AaronRobinsonMSFT @jkoritzinsky
The text was updated successfully, but these errors were encountered: