[DllImportGenerator] Enable on projects without System.Memory and System.Runtime.CompilerServices.Unsafe #61704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
approved these changes
Nov 16, 2021
13 tasks
elinor-fung
force-pushed
the
enableDllImportGeneratorFilter
branch
from
fc15022 to
8719153
Compare
…tem.Runtime.CompilerServices.Unsafe
elinor-fung
force-pushed
the
enableDllImportGeneratorFilter
branch
from
8719153 to
1c61e06
Compare
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't always add
ArrayMarshaller.cs(which usesSystem.MemoryandSystem.Runtime.CompilerServices.Unsafe). This stops requiring that all the libraries projects that use the source generator at all have those references (even though they may not actually need them for the generated code), such that the generator can be enabled for everything.If the generated code does end up needing those references, it will just come through as a compilation error.
Added a check - that should be removed once we add APIs like ArrayMarshaller - so that the generator will fire a diagnostic if targeting 7.0+ and missing an API.
@AaronRobinsonMSFT @jkoritzinsky