Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][aot] Regression: lots of AOT tests failing on main #53697

Closed
radical opened this issue Jun 3, 2021 · 3 comments · Fixed by #53710
Closed

[wasm][aot] Regression: lots of AOT tests failing on main #53697

radical opened this issue Jun 3, 2021 · 3 comments · Fixed by #53710
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono

Comments

@radical
Copy link
Member

radical commented Jun 3, 2021

Number of AOT tests being run on main goes down from ~42k to 173:

Screen Shot 2021-06-03 at 3 52 36 PM

The test runs don't show up as failed, though if you look at the logs then they are mostly crashes, like:

Microsoft.CSharp.Tests:

[17:08:13] fail: ==== JS stack trace =========================================
                 
[17:08:13] fail: 
                 
[17:08:13] fail: Security context: 0x07040820dca9 <JSObject>#0#
                 
[17:08:13] fail:     0: builtin exit frame: trace(this=0x070408203701 <console map = 0x70408240919>#1#,0x070408149df1 <String[98]: c"* Assertion at /__w/1/s/src/mono/mono/mini/mini-exceptions.c:3957, condition `<disabled>' not met\n">,0x070408203701 <console map = 0x70408240919>#1#)
                 
[17:08:13] fail: 
                 
[17:08:13] fail:     1: 5224413 [0x704083d2bf5] [dotnet.js:1431] [bytecode=0x704087efb9d offset=127](this=0x0704083c1a11 <JSGlobal Object>#2#,15107,42563544,4,0,0)
                

According to @vargaz, #52883 should fix these crashes.

TODO (wip): xharness should identify these crashes, and fail the tests

cc @lewing @SamMonoRT @radekdoulik

@radical radical added the arch-wasm WebAssembly architecture label Jun 3, 2021
@ghost
Copy link

ghost commented Jun 3, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Number of AOT tests being run on main goes down from ~42k to 173:

Screen Shot 2021-06-03 at 3 52 36 PM

The test runs don't show up as failed, though if you look at the logs then they are mostly crashes, like:

Microsoft.CSharp.Tests:

[17:08:13] fail: ==== JS stack trace =========================================
                 
[17:08:13] fail: 
                 
[17:08:13] fail: Security context: 0x07040820dca9 <JSObject>#0#
                 
[17:08:13] fail:     0: builtin exit frame: trace(this=0x070408203701 <console map = 0x70408240919>#1#,0x070408149df1 <String[98]: c"* Assertion at /__w/1/s/src/mono/mono/mini/mini-exceptions.c:3957, condition `<disabled>' not met\n">,0x070408203701 <console map = 0x70408240919>#1#)
                 
[17:08:13] fail: 
                 
[17:08:13] fail:     1: 5224413 [0x704083d2bf5] [dotnet.js:1431] [bytecode=0x704087efb9d offset=127](this=0x0704083c1a11 <JSGlobal Object>#2#,15107,42563544,4,0,0)
                

According to @vargaz, #52883 should fix these crashes.

TODO (wip): xharness should identify these crashes, and fail the tests

cc @lewing @SamMonoRT @radekdoulik

Author: radical
Assignees: -
Labels:

arch-wasm

Milestone: -

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 3, 2021
@vargaz
Copy link
Contributor

vargaz commented Jun 4, 2021

This is caused by:
#53482
will fix/revert.

@radical radical added area-Codegen-AOT-mono and removed untriaged New issue has not been triaged by the area owner labels Jun 4, 2021
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 4, 2021
vargaz added a commit to vargaz/runtime that referenced this issue Jun 4, 2021
It cannot determine whenever the finally clause is really empty, i.e. whenever
it can affect the rest of the program.

Fixes dotnet#53697.
vargaz added a commit that referenced this issue Jun 4, 2021
It cannot determine whenever the finally clause is really empty, i.e. whenever
it can affect the rest of the program.

Fixes #53697.
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 4, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants