Assertion failed '(genTypeSize(node->TypeGet()) == 16) || (genTypeSize(node->TypeGet()) == 32)'

[jkotas]

1. Compile:

using System;
using System.Numerics;
using System.Reflection;
using System.Runtime.Intrinsics;

var mi = typeof(Vector128).GetMethod("AsVector128", new Type[] { typeof(Vector2) });
mi.Invoke(null, new object[] { new Vector2() });

2. Run with VEX instruction encoding disabled:

set COMPlus_EnableAVX=0
set COMPlus_EnableSSE41=0
set COMPlus_ReadyToRun=0
corerun test.exe

Result:

Assert failure(PID 24192 [0x00005e80], Thread: 12184 [0x2f98]): Assertion failed '(genTypeSize(node->TypeGet()) == 16) || (genTypeSize(node->TypeGet()) == 32)' in 'System.Runtime.Intrinsics.Vector128:AsVector128(System.Numerics.Vector2):System.Runtime.Intrinsics.Vector128`1[Single]' during 'Lowering nodeinfo' (IL size 22)

    File: C:\runtime\src\coreclr\jit\lowerxarch.cpp Line: 5539
    Image: C:\runtime\artifacts\bin\coreclr\windows.x64.Checked\corerun.exe

[jkotas]

This is regression introduce in last week or so.

[EgorBo]

@tannergooding can it be introduced by #51731 ?

[tannergooding]

Yes, that's likely.

I'd guess that the node can also be TYP_SIMD12 and that code path isn't accounting for the adjustment when doing the calculations. I'll get a repro and then fix.

[tannergooding]

I'm able to repro, this is from #52288 and is because I forgot to add in the node->SetSimdSize(16); during the final fixup.

Validating the fix locally and should have it up shortly.

[VincentBu]

Failed in runtime-coreclr jitstress-isas-x86 20210522.1
Failed tests:

JIT/Regression/JitBlue/Runtime_31615/Runtime_31615/Runtime_31615.sh
JIT/SIMD/CircleInConvex_ro/CircleInConvex_ro.sh
JIT/HardwareIntrinsics/General/Vector128_1/Vector128_1_ro/Vector128_1_ro.sh

Error message:

Assert failure(PID 66508 [0x000103cc], Thread: 2677846 [0x28dc56]): Assertion failed '(genTypeSize(node->TypeGet()) == 16) || (genTypeSize(node->TypeGet()) == 32)' in 'Runtime_31615:G2():System.Numerics.Vector2' during 'Lowering nodeinfo' (IL size 34)

File: /Users/runner/work/1/s/src/coreclr/jit/lowerxarch.cpp Line: 5539
Image: /private/tmp/helix/working/9C4708A3/p/corerun
task_for_pid(66508) FAILED 5 (os/kern) failure
/private/tmp/helix/working/9C4708A3/w/A0B708C8/e/JIT/Regression/JitBlue/Runtime_31615/Runtime_31615/Runtime_31615.sh: line 375: 66508 Abort trap: 6           (core dumped) $LAUNCHER $ExePath "${CLRTestExecutionArguments[@]}"

Return code:      1
Raw output file:      /private/tmp/helix/working/9C4708A3/w/A0B708C8/e/JIT/Regression/Reports/JIT.Regression/JitBlue/Runtime_31615/Runtime_31615/Runtime_31615.output.txt
Raw output:
BEGIN EXECUTION
/tmp/helix/working/9C4708A3/p/corerun Runtime_31615.dll ''
Expected: 100
Actual: 134
END EXECUTION - FAILED
Test Harness Exitcode is : 1
To run the test:

set CORE_ROOT=/tmp/helix/working/9C4708A3/p
/private/tmp/helix/working/9C4708A3/w/A0B708C8/e/JIT/Regression/JitBlue/Runtime_31615/Runtime_31615/Runtime_31615.sh
Expected: True
Actual:   False


Stack trace
   at JIT_Regression._JitBlue_Runtime_31615_Runtime_31615_Runtime_31615_._JitBlue_Runtime_31615_Runtime_31615_Runtime_31615_sh()

[tannergooding]

This has a fix pending review via #52985