Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProcessorCount_Windows_RespectsJobCpuRateAndConfigurationSetting fails on Mono #52910

Open
akoeplinger opened this issue May 18, 2021 · 4 comments
Open

ProcessorCount_Windows_RespectsJobCpuRateAndConfigurationSetting fails on Mono #52910

akoeplinger opened this issue May 18, 2021 · 4 comments
Labels
area-VM-meta-mono disabled-test The test is disabled in source code against the issue runtime-mono specific to the Mono runtime
Milestone
Future

Comments

@akoeplinger
Copy link
Member

The test was added in #52690 but it fails on Mono in the runtime-staging pipeline:

   System.Tests.EnvironmentProcessorCount.ProcessorCount_Windows_RespectsJobCpuRateAndConfigurationSetting(maxRate: 8000, minRate: 0, procCountConfig: "1") [FAIL]
      Assert.Equal() Failure
      Expected: 1
      Actual:   2
      Stack Trace:
        /_/src/libraries/System.Runtime.Extensions/tests/System/Environment.ProcessorCount.cs(165,0): at System.Tests.EnvironmentProcessorCount.ProcessorCount_Windows_RespectsJobCpuRateAndConfigurationSetting(UInt16 maxRate, UInt16 minRate, String procCountConfig)
        /_/src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(378,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Tests.EnvironmentProcessorCount.ProcessorCount_Windows_RespectsJobCpuRateAndConfigurationSetting(maxRate: 2000, minRate: 0, procCountConfig: null) [FAIL]
      Assert.Equal() Failure
      Expected: 1
      Actual:   2
      Stack Trace:
        /_/src/libraries/System.Runtime.Extensions/tests/System/Environment.ProcessorCount.cs(165,0): at System.Tests.EnvironmentProcessorCount.ProcessorCount_Windows_RespectsJobCpuRateAndConfigurationSetting(UInt16 maxRate, UInt16 minRate, String procCountConfig)
        /_/src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(378,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Tests.EnvironmentProcessorCount.ProcessorCount_Windows_RespectsJobCpuRateAndConfigurationSetting(maxRate: 2000, minRate: 0, procCountConfig: " 0x11 ") [FAIL]
      Assert.Equal() Failure
      Expected: 17
      Actual:   2
      Stack Trace:
        /_/src/libraries/System.Runtime.Extensions/tests/System/Environment.ProcessorCount.cs(165,0): at System.Tests.EnvironmentProcessorCount.ProcessorCount_Windows_RespectsJobCpuRateAndConfigurationSetting(UInt16 maxRate, UInt16 minRate, String procCountConfig)
        /_/src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(378,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Tests.EnvironmentProcessorCount.ProcessorCount_Windows_RespectsJobCpuRateAndConfigurationSetting(maxRate: 0, minRate: 0, procCountConfig: "3") [FAIL]
      Assert.Equal() Failure
      Expected: 3
      Actual:   2
      Stack Trace:
        /_/src/libraries/System.Runtime.Extensions/tests/System/Environment.ProcessorCount.cs(165,0): at System.Tests.EnvironmentProcessorCount.ProcessorCount_Windows_RespectsJobCpuRateAndConfigurationSetting(UInt16 maxRate, UInt16 minRate, String procCountConfig)
        /_/src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(378,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
  Finished:    System.Runtime.Extensions.Tests
=== TEST EXECUTION SUMMARY ===
   System.Runtime.Extensions.Tests  Total: 7835, Errors: 0, Failed: 4, Skipped: 3, Time: 10.021s
@akoeplinger akoeplinger added disabled-test The test is disabled in source code against the issue area-VM-meta-mono runtime-mono specific to the Mono runtime labels May 18, 2021
@ghost
Copy link

ghost commented May 18, 2021

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

The test was added in #52690 but it fails on Mono in the runtime-staging pipeline:

   System.Tests.EnvironmentProcessorCount.ProcessorCount_Windows_RespectsJobCpuRateAndConfigurationSetting(maxRate: 8000, minRate: 0, procCountConfig: "1") [FAIL]
      Assert.Equal() Failure
      Expected: 1
      Actual:   2
      Stack Trace:
        /_/src/libraries/System.Runtime.Extensions/tests/System/Environment.ProcessorCount.cs(165,0): at System.Tests.EnvironmentProcessorCount.ProcessorCount_Windows_RespectsJobCpuRateAndConfigurationSetting(UInt16 maxRate, UInt16 minRate, String procCountConfig)
        /_/src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(378,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Tests.EnvironmentProcessorCount.ProcessorCount_Windows_RespectsJobCpuRateAndConfigurationSetting(maxRate: 2000, minRate: 0, procCountConfig: null) [FAIL]
      Assert.Equal() Failure
      Expected: 1
      Actual:   2
      Stack Trace:
        /_/src/libraries/System.Runtime.Extensions/tests/System/Environment.ProcessorCount.cs(165,0): at System.Tests.EnvironmentProcessorCount.ProcessorCount_Windows_RespectsJobCpuRateAndConfigurationSetting(UInt16 maxRate, UInt16 minRate, String procCountConfig)
        /_/src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(378,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Tests.EnvironmentProcessorCount.ProcessorCount_Windows_RespectsJobCpuRateAndConfigurationSetting(maxRate: 2000, minRate: 0, procCountConfig: " 0x11 ") [FAIL]
      Assert.Equal() Failure
      Expected: 17
      Actual:   2
      Stack Trace:
        /_/src/libraries/System.Runtime.Extensions/tests/System/Environment.ProcessorCount.cs(165,0): at System.Tests.EnvironmentProcessorCount.ProcessorCount_Windows_RespectsJobCpuRateAndConfigurationSetting(UInt16 maxRate, UInt16 minRate, String procCountConfig)
        /_/src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(378,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Tests.EnvironmentProcessorCount.ProcessorCount_Windows_RespectsJobCpuRateAndConfigurationSetting(maxRate: 0, minRate: 0, procCountConfig: "3") [FAIL]
      Assert.Equal() Failure
      Expected: 3
      Actual:   2
      Stack Trace:
        /_/src/libraries/System.Runtime.Extensions/tests/System/Environment.ProcessorCount.cs(165,0): at System.Tests.EnvironmentProcessorCount.ProcessorCount_Windows_RespectsJobCpuRateAndConfigurationSetting(UInt16 maxRate, UInt16 minRate, String procCountConfig)
        /_/src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(378,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
  Finished:    System.Runtime.Extensions.Tests
=== TEST EXECUTION SUMMARY ===
   System.Runtime.Extensions.Tests  Total: 7835, Errors: 0, Failed: 4, Skipped: 3, Time: 10.021s
Author: akoeplinger
Assignees: -
Labels:

area-VM-meta-mono, disabled-test, runtime-mono
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label May 18, 2021
akoeplinger added a commit that referenced this issue May 18, 2021
@akoeplinger
Disable ProcessorCount_Windows_RespectsJobCpuRateAndConfigurationSett…
88b7858 
…ing test on Mono

It fails: #52910
@akoeplinger akoeplinger mentioned this issue May 18, 2021
Merged
akoeplinger added a commit that referenced this issue May 18, 2021
@akoeplinger
Disable ProcessorCount_Windows_RespectsJobCpuRateAndConfigurationSett…
53735f7 
…ing test on Mono (#52911)

It fails on Mono in the runtime-staging pipeline: #52910
@mangod9
Copy link
Member

mangod9 commented May 19, 2021

@AntonLapounov as FYI.. perhaps an equivalent change is required for mono?

@AntonLapounov
Copy link
Member

@mangod9 At present Mono does not support cgroup limits on Unix or process affinity on Windows, so it would require more work than just doing an equivalent change.

@CoffeeFlux CoffeeFlux added this to the Future milestone Jun 14, 2021
@CoffeeFlux CoffeeFlux removed the untriaged New issue has not been triaged by the area owner label Jun 14, 2021
@CoffeeFlux
Copy link
Contributor

This seems to mostly matter for containers, which aren't an immediate priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-VM-meta-mono disabled-test The test is disabled in source code against the issue runtime-mono specific to the Mono runtime
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@akoeplinger @CoffeeFlux @AntonLapounov @mangod9