-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many System.Net.Sockets.Tests failed with System.NullReferenceException : Object reference not set to an instance of an object #51480
Comments
Tagging subscribers to this area: @dotnet/ncl Issue DetailsRun: runtime-libraries-coreclr outerloop 20210418.2 Failed tests:
One of Error messages:
|
Very odd, there is no user code explicitly utilizing LINQ in those tests. The stack trace of
So far happened only once, on one particular machine, but multiple tests failing simultaneously. |
if this is only on macOS arm64 there are some known stability issues. we are gradually fixing stress bugs. |
The trace points to Equality assert. (if we can try it) |
Honestly, I doubt this can come from within that assert. Line 474 is: runtime/src/libraries/System.Net.Sockets/tests/FunctionalTests/SendReceive/SendReceive.cs Line 474 in 333a6c7
|
XUnit uses Linq for IEnumerable https://github.com/xunit/assert.xunit/blob/main/CollectionAsserts.cs comparion. Linq uses lot of trickery and possibly parallelism. We would need to probably look at the full core dump to see what is actually NULL. It may not be the buffers. cc: @sdmaclea |
Root cause is probably the same as for the NRE we're seeing on RHEL8 arm64: #43349. |
These tests should all use AssertExtensions.SequenceEqual instead of Assert.Equal anyway. As mentioned above, Assert.Equal does an IEnumerable-based sequence comparison here, which is much much slower than a span-based sequence comparsion (which AssertExtensions.SequenceEqual does). |
Putting perf concerns aside, we are comparing two FYI there were no new occurrences since 18/04. |
I have seen a significant Apple Silicon stability improvement with |
@sdmaclea in that case we should close this issue until it happens again on the new version ... |
We could do that or disable the test until the queues are updated. This PR could hold the I will close now per your recommendation. |
Run: runtime-libraries-coreclr outerloop 20210418.2
Failed tests:
One of Error messages:
The text was updated successfully, but these errors were encountered: