Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failed : System.Data.Tests.AppDomainsAndFormatInfo.Bug55978 #47968

Open
VincentBu opened this issue Feb 7, 2021 · 11 comments
Open

Test failed : System.Data.Tests.AppDomainsAndFormatInfo.Bug55978 #47968

VincentBu opened this issue Feb 7, 2021 · 11 comments
Labels
arch-wasm WebAssembly architecture area-System.Data os-linux Linux OS (any supported distro)
Milestone
Future

Comments

@VincentBu
Copy link
Contributor

Run: runtime 20210206.8

Failed test:

net6.0-Browser-Release-wasm-Mono_Release-wasmtestonbrowser-Ubuntu.1804.Amd64.Open

  -System.Data.Tests.AppDomainsAndFormatInfo.Bug55978

Error message:

Assert.Equal() Failure
Expected: 2
Actual:   3


Stack trace
   at System.Data.Tests.AppDomainsAndFormatInfo.Bug55978()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
@VincentBu VincentBu added area-System.Data os-linux Linux OS (any supported distro) arch-x64 labels Feb 7, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 7, 2021
@ghost
Copy link

ghost commented Feb 7, 2021

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

Run: runtime 20210206.8

Failed test:

net6.0-Browser-Release-wasm-Mono_Release-wasmtestonbrowser-Ubuntu.1804.Amd64.Open

  -System.Data.Tests.AppDomainsAndFormatInfo.Bug55978

Error message:

Assert.Equal() Failure
Expected: 2
Actual:   3


Stack trace
   at System.Data.Tests.AppDomainsAndFormatInfo.Bug55978()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
Author: VincentBu
Assignees: -
Labels:

arch-x64, area-System.Data, os-linux
Milestone: -

@eerhardt
Copy link
Member

Also failed on browser-wasm in #48181, so I don't believe this is x64 specific.

https://helix.dot.net/api/2019-06-17/jobs/05ea776a-fb59-4058-8691-82b19e0ca827/workitems/System.Data.Common.Tests/console

[17:03:32] info: Arguments: --run,WasmTestRunner.dll,System.Data.Common.Tests.dll,-notrait,category=IgnoreForCI,-notrait,category=OuterLoop,-notrait,category=failing
[17:03:33] info: console.debug: MONO_WASM: Initializing mono runtime
[17:03:33] info: console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
[17:03:33] info: console.debug: mono_wasm_runtime_ready fe00e07a-5519-4dfe-b35a-f867dbaf2e28
[17:03:33] info: Initializing.....
[17:03:33] info: Discovering: System.Data.Common.Tests.dll (method display = ClassAndMethod, method display options = None)
[17:03:34] info: Discovered:  System.Data.Common.Tests.dll (found 1787 of 1813 test cases)
[17:03:34] info: Starting:    System.Data.Common.Tests.dll
[17:03:37] fail: [FAIL] System.Data.Tests.AppDomainsAndFormatInfo.Bug55978
[17:03:37] info: Assert.Equal() Failure
[17:03:37] info: Expected: 2
[17:03:37] info: Actual:   3
[17:03:37] info:    at System.Data.Tests.AppDomainsAndFormatInfo.Bug55978()
[17:03:37] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
[17:04:01] info: Finished:    System.Data.Common.Tests.dll
[17:04:01] info: 
[17:04:01] info: === TEST EXECUTION SUMMARY ===
[17:04:01] info: Total: 11692, Errors: 0, Failed: 1, Skipped: 10, Time: 26.736458s

@eerhardt eerhardt mentioned this issue Feb 12, 2021
Merged
@GrabYourPitchforks
Copy link
Member

Also failed in https://github.com/dotnet/runtime/pull/50951/checks?check_run_id=2300492544.

@VincentBu
Copy link
Contributor Author

Failed again in runtime 20210425.28

Failed test:

net6.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open
 -System.Data.Tests.AppDomainsAndFormatInfo.Bug55978

Error message:

Assert.Equal() Failure
Expected: 2
Actual:   3


Stack trace
   at System.Data.Tests.AppDomainsAndFormatInfo.Bug55978()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

@ajcvickers
Copy link
Contributor

@eerhardt What's the appropriate action here? I don't believe we have touched this code in a long time, so it seems likely that if this has recently started failing, then this is due to some wider change.

@ajcvickers ajcvickers added this to the Future milestone Jul 13, 2021
@ajcvickers ajcvickers removed the untriaged New issue has not been triaged by the area owner label Jul 13, 2021
@eerhardt
Copy link
Member

As far as I can tell, this is only failing on wasm, even though the label has arch-x64. I think that label is a mistake because the first instance of this failing says:

net6.0-Browser-Release-wasm-Mono_Release-wasmtestonbrowser-Ubuntu.1804.Amd64.Open

I think it was running browser-wasm on an x64 machine. This is a wasm bug. Fixing the labels.

@eerhardt eerhardt added arch-wasm WebAssembly architecture and removed arch-x64 labels Jul 13, 2021
@ghost
Copy link

ghost commented Jul 13, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Run: runtime 20210206.8

Failed test:

net6.0-Browser-Release-wasm-Mono_Release-wasmtestonbrowser-Ubuntu.1804.Amd64.Open

  -System.Data.Tests.AppDomainsAndFormatInfo.Bug55978

Error message:

Assert.Equal() Failure
Expected: 2
Actual:   3


Stack trace
   at System.Data.Tests.AppDomainsAndFormatInfo.Bug55978()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
Author: VincentBu
Assignees: -
Labels:

arch-wasm, area-System.Data, os-linux
Milestone: Future

@radical
Copy link
Member

radical commented Aug 3, 2021

Failed again - https://dev.azure.com/dnceng/public/_build/results?buildId=1274300&view=logs&jobId=108d2c4a-8a62-5a58-8dad-8e1042acc93c&j=108d2c4a-8a62-5a58-8dad-8e1042acc93c&t=568f884b-cc12-5fd3-e7fe-790b5ac403f4 on https://github.com/dotnet/runtime/pull/56802/checks?check_run_id=3236115645

@lewing do you think this needs to be looked at for 6.0? It has happened only thrice in the last month. But since it's happening only on wasm, and is sporadic, I wonder if it might be hiding some weird bug.

@radical radical mentioned this issue Aug 3, 2021
Merged
@vargaz
Copy link
Contributor

vargaz commented Aug 4, 2021

The test has something to do with dates/times, so it's possible that it only fails at certain dates/times like at midnight etc.

@lewing
Copy link
Member

lewing commented Aug 4, 2021

@radical we could try improving test assertions so that it was clear how it is failing

radical added a commit to radical/runtime that referenced this issue Aug 4, 2021
@radical
[wasm] System.Data.Tests - add debug info, to help with the failure
00dc3a5 
`System.Data.Tests.AppDomainsAndFormatInfo.Bug55978` fails sometimes for
wasm:

```
Assert.Equal() Failure
Expected: 2
Actual:   3

Stack trace
   at System.Data.Tests.AppDomainsAndFormatInfo.Bug55978()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
```

To debug the issue, this dumps some state when the test fails.

Issue: dotnet#47968
@radical radical mentioned this issue Aug 4, 2021
Merged
@radical
Copy link
Member

radical commented Aug 4, 2021

Opened a PR that will dump some info when the test fails - #56838

radical added a commit that referenced this issue Aug 5, 2021
@radical
[wasm] System.Data.Tests - add debug info, to help with the test fail…
f11c8ff 
…ure (#56838)

`System.Data.Tests.AppDomainsAndFormatInfo.Bug55978` fails sometimes for
wasm:

```
Assert.Equal() Failure
Expected: 2
Actual:   3

Stack trace
   at System.Data.Tests.AppDomainsAndFormatInfo.Bug55978()
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
```

To debug the issue, this dumps some state when the test fails.

Issue: #47968
@am11 am11 mentioned this issue Oct 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-System.Data os-linux Linux OS (any supported distro)
Projects
None yet
Milestone
Future
Development

No branches or pull requests
7 participants
@radical @lewing @vargaz @ajcvickers @GrabYourPitchforks @eerhardt @VincentBu