-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IcuLocaleData.NameIndexToNumericData is not linker friendly #47967
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @tannergooding, @sbomer Issue DetailsNameIndexToNumericData is a 15k byte array which cannot be linked out even through much of the information inside it is not needed if not all entries in IcuLocaleDataParts are used by the app. It would be better to have 1 array for every entry in IcuLocaleDataParts.
|
Tagging subscribers to this area: @tarekgh, @safern, @krwq Issue DetailsNameIndexToNumericData is a 15k byte array which cannot be linked out even through much of the information inside it is not needed if not all entries in IcuLocaleDataParts are used by the app. It would be better to have 1 array for each entry in IcuLocaleDataParts.
|
@marek-safar @vargaz we need to decide for such issues if it is nice to have or it has to be fixed in 6.0. To know the priority and plan for that. Or you expecting your team will take care with that? |
This was discussed in #45643 (comment) @tarekgh teams working on size goals will take care of this when it fits into their priorities list. |
I moved it to future milestone for now and can be brought back to 6.0 when is decided otherwise. |
In a
so 6 out of 18 bytes are being used, potentially saving 66% of this table. If this table is 15KB, that means we could potentially save 10KB (uncompressed). |
@tarekgh - been a couple months since this was last discussed - just confirming that we can/cannot fit this in .NET 6 ? (Is the Future milestone still accurate ?) |
@SamMonoRT nothing changes per the comment #47967 (comment). It still marked for future. |
NameIndexToNumericData is a 15k byte array which cannot be linked out even through much of the information inside it is not needed if not all entries in IcuLocaleDataParts are used by the app. It would be better to have 1 array for each entry in IcuLocaleDataParts.
The text was updated successfully, but these errors were encountered: