Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][Browser] Interpreter doesn't fully support UnmanagedCallersOnly #39100

Closed
EgorBo opened this issue Jul 10, 2020 · 3 comments · Fixed by #39700 or mono/mono#20145
Closed

[mono][Browser] Interpreter doesn't fully support UnmanagedCallersOnly #39100

EgorBo opened this issue Jul 10, 2020 · 3 comments · Fixed by #39700 or mono/mono#20145
Assignees
@vargaz
Labels
arch-wasm WebAssembly architecture area-Codegen-Interpreter-mono
Milestone
5.0.0

Comments

@EgorBo
Copy link
Member

EgorBo commented Jul 10, 2020

Currently, the only way to pass a managed callback to a pinvoke in Mono-Wasm-Interp is to use IntPtr + Marshal.GetFunctionPointerForDelegate + MonoPinvokeCallbackAttribute.

/cc @vargaz

I will use link to this issue for workarounds.
@ghost
Copy link

ghost commented Jul 10, 2020

Tagging subscribers to this area: @BrzVlad, @lewurm
Notify danmosemsft if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jul 10, 2020
@EgorBo
Copy link
Member Author

EgorBo commented Jul 16, 2020

Once fixed, MonoPInvokeCallbackAttribute should be removed from System.Private.CoreLib

@EgorBo EgorBo mentioned this issue Jul 16, 2020
Merged
@marek-safar marek-safar removed the untriaged New issue has not been triaged by the area owner label Jul 16, 2020
@marek-safar marek-safar added this to the 5.0.0 milestone Jul 16, 2020
@jkotas
Copy link
Member

jkotas commented Jul 21, 2020

I have extended this workaround to apply to all Mono targets in #39082

jkotas added a commit to jkotas/runtime that referenced this issue Jul 21, 2020
@jkotas
Test dotnet#39100
a9d4be2
vargaz added a commit to vargaz/runtime that referenced this issue Jul 21, 2020
@vargaz
[runtime] Initialize the class if needed in type_is_blittable ().
8fb51c1 
Fixes dotnet#39100.
@vargaz vargaz mentioned this issue Jul 21, 2020
Merged
@monojenkins monojenkins mentioned this issue Jul 21, 2020
Merged
monojenkins pushed a commit to monojenkins/mono that referenced this issue Jul 21, 2020
@vargaz
[runtime] Initialize the class if needed in type_is_blittable ().
696090f 
Fixes dotnet/runtime#39100.
vargaz added a commit that referenced this issue Jul 21, 2020
@vargaz
[runtime] Initialize the class if needed in type_is_blittable (). (#3…
ed6eda5 
…9700)

* [runtime] Initialize the class if needed in type_is_blittable ().

Fixes #39100.

* Delete workarounds.
vargaz added a commit to mono/mono that referenced this issue Jul 21, 2020
@monojenkins @vargaz
[runtime] Initialize the class if needed in type_is_blittable (). (#2…
850af3b 
…0145)

Fixes dotnet/runtime#39100.

Co-authored-by: vargaz <[email protected]>
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this issue Aug 10, 2020
@vargaz @Jacksondr5
[runtime] Initialize the class if needed in type_is_blittable (). (do…
78f3437 
…tnet#39700)

* [runtime] Initialize the class if needed in type_is_blittable ().

Fixes dotnet#39100.

* Delete workarounds.
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vargaz vargaz

Labels
arch-wasm WebAssembly architecture area-Codegen-Interpreter-mono
Projects
None yet
Milestone
5.0.0
5 participants
@vargaz @marek-safar @EgorBo @jkotas @Dotnet-GitSync-Bot