Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JitStress: assert(m_CallsiteDepth > 0) #38374

Closed
sandreenko opened this issue Jun 25, 2020 · 0 comments · Fixed by #38399
Closed

JitStress: assert(m_CallsiteDepth > 0) #38374

sandreenko opened this issue Jun 25, 2020 · 0 comments · Fixed by #38399
Assignees
@AndyAyersMS
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI JitStress CLR JIT issues involving JIT internal stress modes
Milestone
5.0.0

Comments

@sandreenko
Copy link
Contributor

I suspect this PR has caused new failures like (jitstress=1):

Assert failure(PID 2440 [0x00000988], Thread: 9332 [0x2474]): Assertion failed 'm_CallsiteDepth > 0' in '<>c:<GetType>b__1_0(System.String):System.Type:this' during 'Morph - Inlining' (IL size 7)

    File: F:\git\runtime\src\coreclr\src\jit\inlinepolicy.cpp Line: 388
    Image: F:\git\runtime\artifacts\bin\testhost\net5.0-Windows_NT-Release-x64\dotnet.exe

see https://dev.azure.com/dnceng/public/_build/results?buildId=701636&view=ms.vss-test-web.build-test-results-tab&runId=21759702&paneView=debug&resultId=105581 for more examples.

Originally posted by @sandreenko in #38163 (comment)
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI untriaged New issue has not been triaged by the area owner labels Jun 25, 2020
@sandreenko sandreenko added JitStress CLR JIT issues involving JIT internal stress modes and removed untriaged New issue has not been triaged by the area owner labels Jun 25, 2020
@sandreenko sandreenko added this to the 5.0.0 milestone Jun 25, 2020
AndyAyersMS added a commit to AndyAyersMS/runtime that referenced this issue Jun 25, 2020
@AndyAyersMS
JIT: fix inline policy handling of call site depth
fdfed05 
In dotnet#38163 I added a depth field to one of the inline policy base classes.
A derived class already had a similar field. Unify in favor of the base class
field.

The inline policies implemented by these derived policy classes are sometimes
used during jit stress (eg for random inlining).

Fixes dotnet#38374.
@AndyAyersMS AndyAyersMS mentioned this issue Jun 25, 2020
Merged
AndyAyersMS added a commit that referenced this issue Jun 25, 2020
@AndyAyersMS
JIT: fix inline policy handling of call site depth (#38399)
894e930 
In #38163 I added a depth field to one of the inline policy base classes.
A derived class already had a similar field. Unify in favor of the base class
field.

The inline policies implemented by these derived policy classes are sometimes
used during jit stress (eg for random inlining).

Fixes #38374.
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AndyAyersMS AndyAyersMS

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI JitStress CLR JIT issues involving JIT internal stress modes
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

JIT: fix inline policy handling of call site depth AndyAyersMS/runtime
3 participants
@AndyAyersMS @sandreenko @Dotnet-GitSync-Bot