Remove leading and trailing white-spaces from section name (#63549)

* Reproduce the issue with spaces around the section name * Remove leading and trailing whitespaces from section name
dotnet · Jan 11, 2022 · fe8422c · fe8422c
1 parent 1ba2734
commit fe8422c
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/src/libraries/Microsoft.Extensions.Configuration.Ini/src/IniStreamConfigurationProvider.cs b/src/libraries/Microsoft.Extensions.Configuration.Ini/src/IniStreamConfigurationProvider.cs
@@ -50,9 +50,9 @@ public static IDictionary<string, string> Read(Stream stream)
                     {
                         // remove the brackets
 #if NET
-                        sectionPrefix = string.Concat(line.AsSpan(1, line.Length - 2), ConfigurationPath.KeyDelimiter);
+                        sectionPrefix = string.Concat(line.AsSpan(1, line.Length - 2).Trim(), ConfigurationPath.KeyDelimiter);
 #else
-                        sectionPrefix = line.Substring(1, line.Length - 2) + ConfigurationPath.KeyDelimiter;
+                        sectionPrefix = line.Substring(1, line.Length - 2).Trim() + ConfigurationPath.KeyDelimiter;
 #endif
                         continue;
                     }

diff --git a/src/libraries/Microsoft.Extensions.Configuration.Ini/tests/IniConfigurationTest.cs b/src/libraries/Microsoft.Extensions.Configuration.Ini/tests/IniConfigurationTest.cs
@@ -160,6 +160,28 @@ public void SupportAndIgnoreComments()
             Assert.Equal("MySql", iniConfigSrc.Get("Data:Inventory:Provider"));
         }
 
+        [Fact]
+        public void ShouldRemoveLeadingAndTrailingWhiteSpacesFromKeyAndValue()
+        {
+            var ini = "[section]\n" +
+                      " \t key \t = \t value\t ";
+            var iniConfigSrc = new IniConfigurationProvider(new IniConfigurationSource());
+            iniConfigSrc.Load(TestStreamHelpers.StringToStream(ini));
+
+            Assert.Equal("value", iniConfigSrc.Get("section:key"));
+        }
+
+        [Fact]
+        public void ShouldRemoveLeadingAndTrailingWhiteSpacesFromSectionName()
+        {
+            var ini = "[ \t section \t ]\n" +
+                      "key=value";
+            var iniConfigSrc = new IniConfigurationProvider(new IniConfigurationSource());
+            iniConfigSrc.Load(TestStreamHelpers.StringToStream(ini));
+
+            Assert.Equal("value", iniConfigSrc.Get("section:key"));
+        }
+
         [Fact]
         public void ThrowExceptionWhenFoundInvalidLine()
         {