Make service wait on its state before stopping (#84447)

dotnet · Apr 7, 2023 · dcc0d25 · dcc0d25
1 parent 17629fc
commit dcc0d25
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/...braries/Microsoft.Extensions.Hosting.WindowsServices/tests/WindowsServiceLifetimeTests.cs b/...braries/Microsoft.Extensions.Hosting.WindowsServices/tests/WindowsServiceLifetimeTests.cs
@@ -148,9 +148,18 @@ public void ServiceCanStopItself()
                 FileLogger.Log("host.Start()");
                 host.Start();
 
-                FileLogger.Log("host.Stop()");
-                await host.StopAsync();
-                FileLogger.Log("host.Stop() complete");
+                using (ServiceController selfController = new(nameof(ServiceCanStopItself)))
+                {
+                    selfController.WaitForStatus(ServiceControllerStatus.Running, WindowsServiceTester.WaitForStatusTimeout);
+                    Assert.Equal(ServiceControllerStatus.Running, selfController.Status);
+
+                    FileLogger.Log("host.Stop()");
+                    await host.StopAsync();
+                    FileLogger.Log("host.Stop() complete");
+
+                    selfController.WaitForStatus(ServiceControllerStatus.Stopped, WindowsServiceTester.WaitForStatusTimeout);
+                    Assert.Equal(ServiceControllerStatus.Stopped, selfController.Status);
+                }
             }))
             {
                 FileLogger.DeleteLog(nameof(ServiceCanStopItself));

diff --git a/src/libraries/Microsoft.Extensions.Hosting.WindowsServices/tests/WindowsServiceTester.cs b/src/libraries/Microsoft.Extensions.Hosting.WindowsServices/tests/WindowsServiceTester.cs
@@ -48,7 +48,7 @@ private WindowsServiceTester(SafeServiceHandle serviceHandle, RemoteInvokeHandle
             { }
         }
 
-        public TimeSpan WaitForStatusTimeout { get; set; } = TimeSpan.FromSeconds(30);
+        public static TimeSpan WaitForStatusTimeout { get; set; } = TimeSpan.FromSeconds(30);
 
         public new void WaitForStatus(ServiceControllerStatus desiredStatus) =>
             WaitForStatus(desiredStatus, WaitForStatusTimeout);