Skip to content

Commit

Permalink
Close timeout increased to 20 seconds (#34999)
Browse files Browse the repository at this point in the history
CloseOutputAsync_Cancel_Success tests are failing due to 2 reasons:
1. `Assert` expecting the state to be `Aborted`, finds it's `Open` - most frequent
2. Connection gets forcibly terminated on a connect attempt

However, the second failure type is not specific to this test because it affects many tests in different types during the same time. Thus, it seems to be an infra issue.
This PR fixes only the first failure type by increasing Close operation timeout.
Fixes #1725
  • Loading branch information
alnikola authored Apr 15, 2020
1 parent cd024d4 commit d8d7471
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public async Task CloseAsync_Cancel_Success(Uri server)
await TestCancellation(async (cws) =>
{
var ctsDefault = new CancellationTokenSource(TimeOutMilliseconds);
var cts = new CancellationTokenSource(5);
var cts = new CancellationTokenSource(TimeOutMilliseconds);

await cws.SendAsync(
WebSocketData.GetBufferFromText(".delay5sec"),
Expand All @@ -97,7 +97,7 @@ public async Task CloseOutputAsync_Cancel_Success(Uri server)
await TestCancellation(async (cws) =>
{

var cts = new CancellationTokenSource(5);
var cts = new CancellationTokenSource(TimeOutMilliseconds);
var ctsDefault = new CancellationTokenSource(TimeOutMilliseconds);

await cws.SendAsync(
Expand Down

0 comments on commit d8d7471

Please sign in to comment.