Skip to content

Commit

Permalink
also adjust the LSRA for SIMD registers
Browse files Browse the repository at this point in the history
  • Loading branch information
kunalspathak committed Apr 18, 2022
1 parent d870e25 commit c96bcf6
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/coreclr/jit/lsraarmarch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ int LinearScan::BuildCall(GenTreeCall* call)
// the target. We do not handle these constraints on the same
// refposition too well so we help ourselves a bit here by forcing the
// null check with LR.
regMaskTP candidates = call->IsFastTailCall() ? RBM_LR : 0;
regMaskTP candidates = call->IsFastTailCall() ? RBM_LR : RBM_NONE;
buildInternalIntRegisterDefForNode(call, candidates);
}
#endif // TARGET_ARM
Expand Down Expand Up @@ -634,7 +634,7 @@ int LinearScan::BuildBlockStore(GenTreeBlk* blkNode)

const bool isDstRegAddrAlignmentKnown = dstAddr->OperIsLocalAddr();

if (isDstRegAddrAlignmentKnown && (size > FP_REGSIZE_BYTES))
if (/*isDstRegAddrAlignmentKnown && */(size > FP_REGSIZE_BYTES))
{
// For larger block sizes CodeGen can choose to use 16-byte SIMD instructions.
buildInternalFloatRegisterDefForNode(blkNode, internalFloatRegCandidates());
Expand Down Expand Up @@ -713,7 +713,7 @@ int LinearScan::BuildBlockStore(GenTreeBlk* blkNode)
// CodeGen can use 16-byte SIMD ldp/stp for larger block sizes
// only when both source and destination base address registers have known alignment.
// This is the case, when both registers are either sp or fp.
bool canUse16ByteWideInstrs = isSrcAddrLocal && isDstAddrLocal && (size >= 2 * FP_REGSIZE_BYTES);
bool canUse16ByteWideInstrs = /*isSrcAddrLocal && isDstAddrLocal &&*/ (size >= 2 * FP_REGSIZE_BYTES);

// Note that the SIMD registers allocation is speculative - LSRA doesn't know at this point
// whether CodeGen will use SIMD registers (i.e. if such instruction sequence will be more optimal).
Expand Down

0 comments on commit c96bcf6

Please sign in to comment.