Skip to content

Commit

Permalink
Avoid unnecessary lazy init in StructuralComparisons
Browse files Browse the repository at this point in the history
Move the fields to the target types and make them readonly instead of manually lazy.
  • Loading branch information
stephentoub committed Apr 21, 2024
1 parent a3dc133 commit b7769c4
Showing 1 changed file with 6 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,15 @@ namespace System.Collections
{
public static class StructuralComparisons
{
private static volatile IComparer? s_StructuralComparer;
private static volatile IEqualityComparer? s_StructuralEqualityComparer;
public static IComparer StructuralComparer => System.Collections.StructuralComparer.s_instance

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm Debug AllSubsets_Mono)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Debug AllSubsets_Mono_LLVMJIT)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build wasi-wasm linux Release LibraryTests_Smoke_AOT)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build wasi-wasm linux Release LibraryTests_Smoke)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux_musl-x64 Release AllSubsets_Mono)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug AllSubsets_Mono_LLVMJIT)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug Mono_Interpreter_LibrariesTests)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Release AllSubsets_Mono_LLVMAOT)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-riscv64 Release AllSubsets_Mono)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build android-arm Release AllSubsets_Mono)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build android-arm64 Release AllSubsets_Mono)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Release AllSubsets_Mono_LLVMAOT)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / dotnet-linker-tests (Build browser-wasm linux release Runtime_Release)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Release NativeAOT_Libraries)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests_Smoke_AOT)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests_Threading)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests_EAT)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux_musl-arm Debug AllSubsets_CoreCLR_ReleaseRuntimeLibs)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm Debug AllSubsets_CoreCLR_ReleaseRuntimeLibs)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug AllSubsets_Mono_LLVMAOT)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build tvossimulator-x64 Debug AllSubsets_Mono)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build maccatalyst-x64 Release AllSubsets_Mono)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build ios-arm64 Release AllSubsets_NativeAOT)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux_musl-x64 Debug CoreCLR_Libraries)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux_musl-arm64 Debug AllSubsets_CoreCLR_ReleaseRuntimeLibs)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux_musl-x64 Debug AllSubsets_CoreCLR)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Release AllSubsets_Mono_LLVMJIT)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Debug AllSubsets_CoreCLR)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / dotnet-linker-tests (Build linux-x64 release Runtime_Release)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build tvos-arm64 Release AllSubsets_NativeAOT)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-x64 Debug CoreCLR_Libraries)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-arm64 Release NativeAOT_Libraries)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build linux-arm64 Debug Libraries_CheckedCoreCLR)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build tvos-arm64 Release AllSubsets_Mono)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build ios-arm64 Release AllSubsets_Mono)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / dotnet-linker-tests (Build osx-x64 release Runtime_Release)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / dotnet-linker-tests

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / dotnet-linker-tests

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / dotnet-linker-tests

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug Libraries_CheckedCoreCLR)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-x64 Debug CoreCLR_Libraries)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime (Build osx-arm64 Debug AllSubsets_CoreCLR)

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime-dev-innerloop

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

Check failure on line 10 in src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs

View check run for this annotation

Azure Pipelines / runtime-dev-innerloop

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs#L10

src/libraries/System.Collections/src/System/Collections/StructuralComparisons.cs(10,103): error CS1002: (NETCORE_ENGINEERING_TELEMETRY=Build) ; expected

public static IComparer StructuralComparer => s_StructuralComparer ??= new StructuralComparer();

public static IEqualityComparer StructuralEqualityComparer => s_StructuralEqualityComparer ??= new StructuralEqualityComparer();
public static IEqualityComparer StructuralEqualityComparer => System.Collections.StructuralEqualityComparer.s_instance;
}

internal sealed class StructuralEqualityComparer : IEqualityComparer
{
internal static readonly StructuralEqualityComparer s_instance = new();

public new bool Equals(object? x, object? y)
{
if (x != null)
Expand Down Expand Up @@ -58,6 +57,8 @@ public int GetHashCode(object obj)

internal sealed class StructuralComparer : IComparer
{
internal static readonly StructuralComparer s_instance = new();

public int Compare(object? x, object? y)
{
if (x == null) return y == null ? 0 : -1;
Expand Down

0 comments on commit b7769c4

Please sign in to comment.