Ensure we always consume the rounding mode operand and produce the re…

…gister
dotnet · Jan 27, 2024 · b19a4c5 · b19a4c5
1 parent cffe6ba
commit b19a4c5
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/src/coreclr/jit/hwintrinsiccodegenxarch.cpp b/src/coreclr/jit/hwintrinsiccodegenxarch.cpp
@@ -194,6 +194,7 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node)
                 if (lastOp->isContained())
                 {
                     assert(lastOp->IsCnsIntOrI());
+
                     int8_t mode = static_cast<int8_t>(lastOp->AsIntCon()->IconValue());
                     instOptions = AddEmbRoundingMode(instOptions, mode);
                 }
@@ -207,14 +208,13 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node)
                     emitAttr simdSize = emitActualTypeSize(Compiler::getSIMDTypeForSize(node->GetSimdSize()));
                     assert(simdSize != 0);
 
+                    genConsumeMultiOpOperands(node);
+                    genConsumeRegs(lastOp);
+
                     switch (numArgs)
                     {
                         case 2:
                         {
-                            genConsumeRegs(node->Op(1));
-                            genConsumeRegs(node->Op(2));
-                            genConsumeRegs(lastOp);
-
                             auto emitSwCase = [&](int8_t i) {
                                 insOpts newInstOptions = AddEmbRoundingMode(instOptions, i);
                                 genHWIntrinsic_R_R_RM(node, ins, simdSize, newInstOptions);
@@ -231,6 +231,9 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node)
                             unreached();
                         }
                     }
+
+                    genProduceReg(node);
+                    return;
                 }
             }
         }
@@ -558,6 +561,7 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node)
                 unreached();
                 break;
         }
+
         genProduceReg(node);
         return;
     }