Skip to content

Commit

Permalink
Revert "Compile System.Private.CoreLib with Crossgen2 by default (#44618
Browse files Browse the repository at this point in the history
)" (#45320)

* Revert "Compile System.Private.CoreLib with Crossgen2 by default (#44618)"

This reverts commit b79e4d3.

* Add a change to ensure libraries are built/tested
  • Loading branch information
stephentoub authored Nov 30, 2020
1 parent c1b5ac0 commit 9528b1d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/coreclr/crossgen-corelib.proj
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<Target Name="Build">
<PropertyGroup>
<!-- Default for using Crossgen2 when not set externally -->
<UseCrossgen2 Condition="'$(UseCrossgen2)' == ''">true</UseCrossgen2>
<UseCrossgen2 Condition="'$(UseCrossgen2)' == ''">false</UseCrossgen2>

<OSPlatformConfig>$(TargetOS).$(TargetArchitecture).$(Configuration)</OSPlatformConfig>
<RootBinDir>$(RepoRoot)\artifacts</RootBinDir>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ internal abstract class AsyncOperation
protected static readonly Action<object?> s_availableSentinel = AvailableSentinel; // named method to help with debugging
private static void AvailableSentinel(object? s) => Debug.Fail($"{nameof(AsyncOperation)}.{nameof(AvailableSentinel)} invoked with {s}");

/// <summary>Sentinel object used in a field to indicate the operation has completed.</summary>
/// <summary>Sentinel object used in a field to indicate the operation has completed</summary>
protected static readonly Action<object?> s_completedSentinel = CompletedSentinel; // named method to help with debugging
private static void CompletedSentinel(object? s) => Debug.Fail($"{nameof(AsyncOperation)}.{nameof(CompletedSentinel)} invoked with {s}");

Expand Down

0 comments on commit 9528b1d

Please sign in to comment.