Skip to content

Commit

Permalink
Fix various typos (#43073)
Browse files Browse the repository at this point in the history
* Fix various typos
* `occurence`, `occurance` -> `occurrence`
* `accross` -> `across`
* `adddress`, `addresss` -> `address`
* `alignement`, `aligment` -> `alignment`
* Remove `c` from triple c.
* Remove `s` from triple s.
  * In palsuite, `Successs` (with triple s) was in commented out
    `Trace()` message, removed all commented out `Trace()` calls
    from such files.
* Fix invalid markdown in `unix-test-instructions.md`.

* Revert event source change
  • Loading branch information
am11 authored Oct 10, 2020
1 parent 730215a commit 4486164
Show file tree
Hide file tree
Showing 90 changed files with 574 additions and 656 deletions.
2 changes: 1 addition & 1 deletion docs/design/coreclr/jit/first-class-structs.md
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ static foo getfoo() { return new foo(); }
the struct may or may not be passed or returned directly.
* Unfortunately, there is not currently a scenario or test case for this issue.

* [\#10879 Unix: Unnecessary struct copy while passsing struct of size <=16](https://github.com/dotnet/runtime/issues/10879)
* [\#10879 Unix: Unnecessary struct copy while passing struct of size <=16](https://github.com/dotnet/runtime/issues/10879)
* [\#9839 [RyuJIT] Eliminate unecessary copies when passing structs](https://github.com/dotnet/runtime/issues/9839)
* These require changing both the callsite and the callee to avoid copying the parameter onto the stack.

Expand Down
4 changes: 2 additions & 2 deletions docs/workflow/ci/coreclr-ci-health.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# CI Health and Investigation

`dotnet/runtime` runs testing accross many different architectures and operating systems. The breadth of testing that happens lends itself to a complex system which is susceptible to different points of failure.
`dotnet/runtime` runs testing across many different architectures and operating systems. The breadth of testing that happens lends itself to a complex system which is susceptible to different points of failure.

Note that this document focuses on coreclr testing in `dotnet/runtime`.

Expand Down Expand Up @@ -103,7 +103,7 @@ In order to view the analytics of the pipeline navigate to [runtime-coreclr](htt

**Pipeline Pass Rate**

This is tracking the pipeline pass rate generally over two weeks. This view is not very useful for [runtime-coreclr](https://dev.azure.com/dnceng/public/_build?definitionId=649) as the PR pipeline is expected to break during PR validation. Therefore, it is generally recommended to view [runtime-coreclr outerloop](https://dev.azure.com/dnceng/public/_build?definitionId=655) to get a better idea of what the overall success rate is for [runtime-coreclr](https://dev.azure.com/dnceng/public/_build?definitionId=228). Note that this is not exactly a fair comparison as we run signicantly more tests in [runtime-outerloop](https://dev.azure.com/dnceng/public/_build?definitionId=655) accross more platforms. It is however, a good proxy to see the overall CI health.
This is tracking the pipeline pass rate generally over two weeks. This view is not very useful for [runtime-coreclr](https://dev.azure.com/dnceng/public/_build?definitionId=649) as the PR pipeline is expected to break during PR validation. Therefore, it is generally recommended to view [runtime-coreclr outerloop](https://dev.azure.com/dnceng/public/_build?definitionId=655) to get a better idea of what the overall success rate is for [runtime-coreclr](https://dev.azure.com/dnceng/public/_build?definitionId=228). Note that this is not exactly a fair comparison as we run signicantly more tests in [runtime-outerloop](https://dev.azure.com/dnceng/public/_build?definitionId=655) across more platforms. It is however, a good proxy to see the overall CI health.

Opening the [runtime-outerloop Pipeline Pass Rate](https://dev.azure.com/dnceng/public/_pipeline/analytics/stageawareoutcome?definitionId=655&contextType=build) there is a presentation of a line graph of the end to end success rate for the pipeline over time.

Expand Down
5 changes: 3 additions & 2 deletions docs/workflow/testing/coreclr/unix-test-instructions.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ PAL tests

Build CoreCLR with PAL tests on the Unix machine:

```sh ./build.sh clr.paltests
```sh
./build.sh clr.paltests
```

Run tests:
Expand All @@ -100,4 +101,4 @@ artifacts/bin/coreclr/$(uname).x64.Debug/paltests/runpaltests.sh $(pwd)/artifact
Test results will go into: `/tmp/PalTestOutput/default/pal_tests.xml`

To disable tests in the CI edit
`src/coreclr/src/pal/tests/palsuite/issues.targets`
`src/coreclr/src/pal/tests/palsuite/issues.targets`
2 changes: 1 addition & 1 deletion eng/pipelines/coreclr/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -165,5 +165,5 @@ jobs:
jobTemplate: /eng/pipelines/coreclr/templates/format-job.yml
platforms:
- Linux_x64
# Isssue: https://github.com/dotnet/runtime/issues/40034
# Issue: https://github.com/dotnet/runtime/issues/40034
#- Windows_NT_x64
2 changes: 1 addition & 1 deletion eng/pipelines/runtime.yml
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ jobs:
jobTemplate: /eng/pipelines/coreclr/templates/format-job.yml
platforms:
- Linux_x64
# Isssue: https://github.com/dotnet/runtime/issues/40034
# Issue: https://github.com/dotnet/runtime/issues/40034
#- Windows_NT_x64
jobParameters:
condition: >-
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/src/binder/inc/assembly.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ namespace BINDER_SPACE
#ifndef CROSSGEN_COMPILE
protected:
#endif
// Asssembly Flags
// Assembly Flags
enum
{
FLAG_NONE = 0x00,
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/src/debug/daccess/daccess.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6639,7 +6639,7 @@ bool ClrDataAccess::GetILImageNameFromNgenImage( LPCWSTR ilExtension,
if (wszFileExtension != 0)
{
LPWSTR wszNextFileExtension = wszFileExtension;
// Find last occurence
// Find last occurrence
do
{
wszFileExtension = wszNextFileExtension;
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/src/debug/daccess/dacdbiimpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ BOOL DacDbiInterfaceImpl::IsLeftSideInitialized()
}


// Determines if a given adddress is a CLR stub.
// Determines if a given address is a CLR stub.
BOOL DacDbiInterfaceImpl::IsTransitionStub(CORDB_ADDRESS address)
{
DD_ENTER_MAY_THROW;
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/src/debug/daccess/dacdbiimpl.h
Original file line number Diff line number Diff line change
Expand Up @@ -733,7 +733,7 @@ class DacDbiInterfaceImpl :

void GetModuleForDomainFile(VMPTR_DomainFile vmDomainFile, OUT VMPTR_Module * pModule);

// Yields true if the adddress is a CLR stub.
// Yields true if the address is a CLR stub.
BOOL IsTransitionStub(CORDB_ADDRESS address);

// Get the "type" of address.
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/src/debug/daccess/fntableaccess.h
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ struct FakeStub
UINT32 m_signature;
#else
#ifdef HOST_64BIT
//README ALIGNEMENT: in retail mode UINT m_numCodeBytes does not align to 16byte for the code
//README ALIGNMENT: in retail mode UINT m_numCodeBytes does not align to 16byte for the code
// after the Stub struct. This is to pad properly
UINT m_pad_code_bytes;
#endif // HOST_64BIT
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/src/debug/di/eventredirectionpipeline.h
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ class EventRedirectionPipeline :

// Command parameters for create case.
// Note that we must always physically call CreateProcess on the debuggee so that we get the proper out-parameters
// from create-processs (eg, target's handle, startup info, etc). So we always attach the auxillary debugger
// from create-process (eg, target's handle, startup info, etc). So we always attach the auxillary debugger
// even in the create case. Use "-pr -pb" in Windbg to attach to a create-suspended process.
//
// Common Windbg options:
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/src/debug/di/rspriv.h
Original file line number Diff line number Diff line change
Expand Up @@ -2533,7 +2533,7 @@ class CordbAppDomain : public CordbBase,

// Unique objects that represent the use of some
// basic ELEMENT_TYPE's as type parameters. These
// are shared acrosss the entire process. We could
// are shared across the entire process. We could
// go and try to find the classes corresponding to these
// element types but it seems simpler just to keep
// them as special cases.
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/src/debug/di/rsthread.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2254,7 +2254,7 @@ HRESULT CordbThread::HasUnhandledException()
// ppStackWalk - out parameter; return the new stackwalker
//
// Return Value:
// Return S_OK on succcess.
// Return S_OK on success.
// Return E_FAIL on error.
//
// Notes:
Expand Down
4 changes: 2 additions & 2 deletions src/coreclr/src/debug/ee/debugger.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1899,7 +1899,7 @@ void Debugger::CleanupTransportSocket(void)
// Initialize Left-Side debugger object
//
// Return Value:
// S_OK on successs. May also throw.
// S_OK on success. May also throw.
//
// Assumptions:
// This is called in the startup path.
Expand Down Expand Up @@ -12896,7 +12896,7 @@ class EnCSequencePointHelper
//
EnCSequencePointHelper::EnCSequencePointHelper(DebuggerJitInfo *pJitInfo)
: m_pJitInfo(pJitInfo),
m_pOffsetToHandlerInfo(NULL)
m_pOffsetToHandlerInfo(NULL)
{
CONTRACTL
{
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/src/debug/ee/debugger.h
Original file line number Diff line number Diff line change
Expand Up @@ -3361,7 +3361,7 @@ class DebuggerEvalBreakpointInfoSegment
/* ------------------------------------------------------------------------ *
* DebuggerEval class
*
* Note that arguments get passsed in a block allocated when
* Note that arguments get passed in a block allocated when
* the func-eval is set up. The setup phase passes the total count of arguments.
*
* In some situations type arguments must also be passed, e.g.
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/src/debug/ee/i386/dbghelpers.S
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ NESTED_ENTRY FuncEvalHijack, _TEXT, UnhandledExceptionHandlerUnix
CHECK_STACK_ALIGNMENT
call C_FUNC(FuncEvalHijackWorker)
add esp, (4 + STK_ALIGN_PADDING)
jmp eax // return is the patch addresss to jmp to
jmp eax // return is the patch address to jmp to
#undef STK_ALIGN_PADDING
NESTED_END FuncEvalHijack, _TEXT

Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/src/debug/ee/i386/dbghelpers.asm
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
_FuncEvalHijack@0 proc public
push eax ; the ptr to the DebuggerEval
call _FuncEvalHijackWorker@4
jmp eax ; return is the patch addresss to jmp to
jmp eax ; return is the patch address to jmp to
_FuncEvalHijack@0 endp


Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/src/debug/ildbsymlib/symread.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1945,7 +1945,7 @@ SymMethod::GetRanges(
{

// Search through all the sequence points since line might have there
// IL spread accross multiple ranges (for loops for example)
// IL spread across multiple ranges (for loops for example)
if (m_pData->m_pSequencePoints[point].Document() == DocumentEntry &&
line >= m_pData->m_pSequencePoints[point].StartLine() &&
line <= m_pData->m_pSequencePoints[point].EndLine())
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/src/debug/inc/dbgtransportsession.h
Original file line number Diff line number Diff line change
Expand Up @@ -793,7 +793,7 @@ class DbgTransportSession

// Upon receiving a reply message, signal the event on the message to wake up the thread waiting for
// the reply message and close the handle to the event.
void SignalReplyEvent(Message * pMesssage);
void SignalReplyEvent(Message * pMessage);

// Given a message ID, find the matching message in the send queue. If there is no match, return NULL.
// If there is a match, remove the message from the send queue and return it.
Expand Down
Loading

0 comments on commit 4486164

Please sign in to comment.