Skip to content

Commit

Permalink
Merge in 'release/6.0' changes
Browse files Browse the repository at this point in the history
  • Loading branch information
dotnet-bot committed May 16, 2022
2 parents bbaceb6 + 15626cf commit 4286d0e
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions src/coreclr/debug/ee/debugger.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2719,7 +2719,6 @@ DebuggerJitInfo *Debugger::GetJitInfoWorker(MethodDesc *fd, const BYTE *pbAddr,
// This may take the lock and lazily create an entry, so we do it up front.
dji = dmi->GetLatestJitInfo(fd);


DebuggerDataLockHolder debuggerDataLockHolder(this);

// Note the call to GetLatestJitInfo() will lazily create the first DJI if we don't already have one.
Expand All @@ -2730,6 +2729,7 @@ DebuggerJitInfo *Debugger::GetJitInfoWorker(MethodDesc *fd, const BYTE *pbAddr,
break;
}
}

LOG((LF_CORDB, LL_INFO1000, "D::GJI: for md:0x%x (%s::%s), got dmi:0x%x.\n",
fd, fd->m_pszDebugClassName, fd->m_pszDebugMethodName,
dmi));
Expand Down Expand Up @@ -2757,7 +2757,9 @@ DebuggerJitInfo *Debugger::GetJitInfoWorker(MethodDesc *fd, const BYTE *pbAddr,
LOG((LF_CORDB,LL_INFO1000,"Couldn't find a DJI by address 0x%p, "
"so it might be a stub or thunk\n", pbAddr));
TraceDestination trace;

// Nothing here needs the data lock anymore, and GetJitInfo will grab the lock as needed.
// However, tracing may go into code versioning paths and this lock can't be held for that.
debuggerDataLockHolder.Release();
g_pEEInterface->TraceStub((const BYTE *)pbAddr, &trace);

if ((trace.GetTraceType() == TRACE_MANAGED) && (pbAddr != (const BYTE *)trace.GetAddress()))
Expand Down Expand Up @@ -16507,7 +16509,7 @@ HRESULT DebuggerHeap::Init(BOOL fExecutable)
return E_OUTOFMEMORY;
}
}
#endif
#endif

#endif // !DACCESS_COMPILE

Expand Down

0 comments on commit 4286d0e

Please sign in to comment.