Skip to content

Commit

Permalink
Enable DwarfDump AOT test in Release (#82862)
Browse files Browse the repository at this point in the history
* Enable DwarfDump AOT test in Release

There are some reports (#82802) that debugging might be particularly bad
in Release.

* Update warning counts for Release
  • Loading branch information
agocke authored Mar 9, 2023
1 parent 3c3bea2 commit 3e73be1
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/tests/nativeaot/SmokeTests/DwarfDump/DwarfDump.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
<OutputType>Exe</OutputType>
<CLRTestKind>BuildAndRun</CLRTestKind>
<CLRTestPriority>0</CLRTestPriority>
<!-- Test checks symbols, so don't run in non-debug builds. -->
<CLRTestTargetUnsupported Condition="'$(Configuration)' != 'Debug' or '$(TargetOS)' != 'linux'">true</CLRTestTargetUnsupported>
<!-- Currently only tracking DWARF info on Linux -->
<CLRTestTargetUnsupported Condition="'$(TargetOS)' != 'linux'">true</CLRTestTargetUnsupported>
</PropertyGroup>

<ItemGroup>
Expand Down
5 changes: 5 additions & 0 deletions src/tests/nativeaot/SmokeTests/DwarfDump/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,13 @@ public static int Main(string[] args)
});

// Just count the number of warnings and errors. There are so many right now that it's not worth enumerating the list
#if DEBUG
const int MinWarnings = 17000;
const int MaxWarnings = 18500;
#else
const int MinWarnings = 12000;
const int MaxWarnings = 13000;
#endif
int count = 0;
string line;
while ((line = proc.StandardOutput.ReadLine()) != null)
Expand Down

0 comments on commit 3e73be1

Please sign in to comment.