Use double.Parse on span instead of string in Unix ping (#32423)

Avoids a string allocation.
dotnet · Feb 17, 2020 · 17c6c26 · 17c6c26
1 parent ceaeefe
commit 17c6c26
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/libraries/Common/src/System/Net/NetworkInformation/UnixCommandLinePing.cs b/src/libraries/Common/src/System/Net/NetworkInformation/UnixCommandLinePing.cs
@@ -156,8 +156,8 @@ public static long ParseRoundTripTime(string pingOutput)
             int afterTime = timeIndex + "time=".Length;
             int msIndex = pingOutput.IndexOf("ms", afterTime, StringComparison.Ordinal);
             int numLength = msIndex - afterTime - 1;
-            string timeSubstring = pingOutput.Substring(afterTime, numLength);
-            double parsedRtt = double.Parse(timeSubstring, CultureInfo.InvariantCulture);
+            ReadOnlySpan<char> timeSubstring = pingOutput.AsSpan(afterTime, numLength);
+            double parsedRtt = double.Parse(timeSubstring, provider: CultureInfo.InvariantCulture);
             return (long)Math.Round(parsedRtt);
         }
     }