Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SymbolRenamer public #1161

Merged
merged 22 commits into from
Aug 19, 2023
Merged

Make SymbolRenamer public #1161

merged 22 commits into from
Aug 19, 2023

Conversation

josefpihrt
Copy link
Collaborator

@josefpihrt josefpihrt commented Aug 16, 2023

fixes #1156

@amsam0
Copy link

amsam0 commented Aug 16, 2023

What's left to be done for this? If needed, I can probably help

@josefpihrt
Copy link
Collaborator Author

@naturecodevoid Following things would be helpful:

  • Add some unit tests for SymbolRenamer (this would be the most helpful)
  • Go through the API (as listed in PR's comment) and check if it fits your need.
  • Download and install nuget Roslynator.Workspaces.Core from PR's artifacts and test it locally.
  • Go through code and make comments

@amsam0
Copy link

amsam0 commented Aug 16, 2023

The API looks like it will work for me. Ideally I would be able to use the SymbolRenamer on C# files in-memory without writing them to disk, but I don't think Roslyn's API allows for this.

I'm not the most experienced C# developer, but I'll try to add some unit tests and make a PR.

@josefpihrt josefpihrt marked this pull request as ready for review August 19, 2023 18:03
@josefpihrt josefpihrt merged commit 81ef8a8 into main Aug 19, 2023
@josefpihrt josefpihrt deleted the feature/symbol-renamer branch August 19, 2023 20:11
Haarmees pushed a commit to Haarmees/Roslynator that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Make SymbolRenamer and other internal APIs publicly accessible
2 participants