Fix RCS1055 (#1361)

dotnet · Jan 14, 2024 · b350632 · b350632
1 parent 2057d5d
commit b350632
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 5 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- Fix analyzer [RCS1055](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1055) ([PR](https://github.com/dotnet/roslynator/pull/1361))
+
 ## [4.9.0] - 2024-01-10
 
 ### Added

diff --git a/src/Analyzers/CSharp/Analysis/UnnecessarySemicolonAtEndOfDeclarationAnalyzer.cs b/src/Analyzers/CSharp/Analysis/UnnecessarySemicolonAtEndOfDeclarationAnalyzer.cs
@@ -121,12 +121,15 @@ private static void AnalyzeEnumDeclaration(SyntaxNodeAnalysisContext context)
     {
         var declaration = (EnumDeclarationSyntax)context.Node;
 
-        SyntaxToken semicolon = declaration.SemicolonToken;
-
-        if (semicolon.Parent is not null
-            && !semicolon.IsMissing)
+        if (declaration.CloseBraceToken.IsKind(SyntaxKind.CloseBraceToken))
         {
-            DiagnosticHelpers.ReportDiagnostic(context, DiagnosticRules.UnnecessarySemicolonAtEndOfDeclaration, semicolon);
+            SyntaxToken semicolon = declaration.SemicolonToken;
+
+            if (semicolon.Parent is not null
+                && !semicolon.IsMissing)
+            {
+                DiagnosticHelpers.ReportDiagnostic(context, DiagnosticRules.UnnecessarySemicolonAtEndOfDeclaration, semicolon);
+            }
         }
     }
 }
diff --git a/src/Tests/Analyzers.Tests/RCS1055UnnecessarySemicolonAtEndOfDeclarationAnalyzerTests.cs b/src/Tests/Analyzers.Tests/RCS1055UnnecessarySemicolonAtEndOfDeclarationAnalyzerTests.cs
@@ -33,6 +33,14 @@ public async Task TestNoDiagnostic_Interface()
     {
         await VerifyNoDiagnosticAsync(@"
 interface C;
+");
+    }
+
+    [Fact, Trait(Traits.Analyzer, DiagnosticIdentifiers.UnnecessarySemicolonAtEndOfDeclaration)]
+    public async Task TestNoDiagnostic_Enum()
+    {
+        await VerifyNoDiagnosticAsync(@"
+enum E;
 ");
     }
 }