Fix RCS1213 (#1254)

dotnet · Nov 18, 2023 · 71172ab · 71172ab
1 parent d2c246a
commit 71172ab
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 0 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 
 - Fix [RCS1228](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1228) ([PR](https://github.com/dotnet/roslynator/pull/1249))
+- Fix [RCS1213](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1213) ([PR](https://github.com/dotnet/roslynator/pull/1254))
 
 ## [4.6.2] - 2023-11-10
 

diff --git a/src/Analyzers/CSharp/Analysis/UnusedMember/UnusedMemberWalker.cs b/src/Analyzers/CSharp/Analysis/UnusedMember/UnusedMemberWalker.cs
@@ -229,18 +229,21 @@ public override void VisitNamespaceDeclaration(NamespaceDeclarationSyntax node)
     public override void VisitClassDeclaration(ClassDeclarationSyntax node)
     {
         VisitAttributeLists(node.AttributeLists);
+        VisitParameterList(node.ParameterList);
         VisitMembers(node.Members);
     }
 
     public override void VisitInterfaceDeclaration(InterfaceDeclarationSyntax node)
     {
         VisitAttributeLists(node.AttributeLists);
+        VisitParameterList(node.ParameterList);
         VisitMembers(node.Members);
     }
 
     public override void VisitStructDeclaration(StructDeclarationSyntax node)
     {
         VisitAttributeLists(node.AttributeLists);
+        VisitParameterList(node.ParameterList);
         VisitMembers(node.Members);
     }
 

diff --git a/src/Tests/Analyzers.Tests/RCS1213RemoveUnusedMemberDeclarationTests.cs b/src/Tests/Analyzers.Tests/RCS1213RemoveUnusedMemberDeclarationTests.cs
@@ -388,4 +388,24 @@ class MonoBehaviour
 }
 ", options: Options.AddConfigOption(ConfigOptionKeys.UnityCodeAnalysisEnabled, true));
     }
+
+    [Fact, Trait(Traits.Analyzer, DiagnosticIdentifiers.RemoveUnusedMemberDeclaration)]
+    public async Task TestNoDiagnostic_PrimaryConstructor()
+    {
+        await VerifyNoDiagnosticAsync(@"
+using System;
+
+class Class([My(Class.Const)] int i)
+{
+    private const string Const = ""const"";
+}
+
+class MyAttribute : Attribute
+{
+    public MyAttribute(string s)
+    {
+    }
+}
+", options: Options.AddAllowedCompilerDiagnosticId("CS9113"));
+    }
 }