Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse engineered positional matching #9023

Merged

Conversation

gafter
Copy link
Member

@gafter gafter commented Feb 22, 2016

Implements recursive (positional) pattern matching by reverse-engineering the relationship between positions and properties by examining the names of constructor parameters. This is an experiment that we're likely to give to users to get feedback about the approach.

See also #8415

@AlekseyTs Please have a look.

@gafter gafter added Area-Compilers 4 - In Review A fix for the issue is submitted for review. Feature - Pattern Matching Pattern Matching labels Feb 22, 2016
@gafter gafter added this to the 2.0 (Preview) milestone Feb 22, 2016
@natidea
Copy link
Contributor

natidea commented Feb 23, 2016

@dotnet/roslyn-infrastructure
Failures in prtest/win/dbg/unit32 and prtest/win/dbg/unit64 are related to #8807 have be resolved in stabilization by #8899 and #8979. Those changes need to make it into this feature branch to unblock these builds

reverse-engineering the relationship between positions and properties
by examining the names of constructor parameters.
See also dotnet#8415
@gafter gafter force-pushed the reverse-engineered-positional-matching branch from 0278cf6 to 936e40d Compare February 23, 2016 18:04
language features (/features=patterns) and more experimental features not
yet fully supported (/features=patternsExperimental).
@gafter gafter modified the milestones: 2.0 (RC), 2.0 (Preview) Feb 25, 2016
… expressions.

Modify pattern matching tests to use new "patternsExperimental" flag for
those pattern-matching features not yet ready for prime time.
gafter added a commit that referenced this pull request Feb 26, 2016
…tching

Reverse engineered positional matching
@gafter gafter merged commit abeed94 into dotnet:features/patterns Feb 26, 2016
@gafter gafter deleted the reverse-engineered-positional-matching branch May 24, 2018 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - In Review A fix for the issue is submitted for review. Area-Compilers cla-already-signed Feature - Pattern Matching Pattern Matching
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants