Throttle async event queues #7784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related issue - icsharpcode/RefactoringEssentials#159 |
|
if this is not sufficient, we can make it a bit better by holding onto only last event and cancel out middle ones for same key (document, analyzer) |
|
@dotnet-bot retest prtest/mac/dbg/unit32 please |
|
retest mac test since the failure was timeout on cloning repo. |
| @@ -181,7 +181,7 @@ internal CompilationWithAnalyzers GetCompilationWithAnalyzers(Project project, C | |||
| var data = await _executor.GetSyntaxAnalysisDataAsync(userDiagnosticDriver, stateSet, versions).ConfigureAwait(false); | |||
| if (data.FromCache) | |||
| { | |||
| RaiseDiagnosticsCreated(StateType.Syntax, document.Id, stateSet, new SolutionArgument(document), data.Items); | |||
| RaiseDiagnosticCreatedFromCacheIfNeeded(StateType.Syntax, document, stateSet, data.Items); | |||
There was a problem hiding this comment.
Naming: RaiseDiagnostics instead of RaiseDiagnostic?
|
👍 |
|
Failure seems related: |
|
it looks like race was always there, but surfaced due to this change where events are now throttled. currently testing fix for the race (basically explicitly check that events are fired) |
the race itself already existed but this PR made the race to surface.
|
@dotnet-bot retest prtest/win/dbg/eta please |
|
made eta to be retested. issues was immutable dll being locked by other process. |
heejaechang
added a commit
that referenced
this pull request
Jan 6, 2016
Throttle async event queues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we had several reports saying we sometime OOM. investigation shows that we have a lot of async events pending especially around removing documents (ex, close solution, vs shutdown, solution re-analysis and etc).
pending events itself is not that much problem, but data captured for the events sometimes accumulated too much which can cause us to OOM.
this change puts a throttle to async events queue so that we block event producers if too many events are flooded to the queue. queue will be unblocked as pending events are processed by consumers.
...
I also changed some parts of engine not to raise unnecessary events.