Avoid async deadlock in InteractiveHost... #7775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scheduler returned by TaskScheduler.FromCurrentSynchronizationContext does not allow concurrency (meaning all Tasks within a submission were being inlined). This would nearly always result in a deadlock if you kicked off a child Task and attempted to continue within the same submission. We can instead use the Winforms Dispatcher, which will invoke the parent Task on the "UI" thread but allow child Tasks to use the ThreadPool.
|
FYI @dotnet/roslyn-interactive |
| @@ -443,7 +443,7 @@ internal new Task<ScriptState<T>> ContinueAsync(ScriptState previousState, Cance | |||
|
|
|||
| private async Task<ScriptState<T>> RunSubmissionsAsync(ScriptExecutionState executionState, ImmutableArray<Func<object[], Task>> precedingExecutors, Func<object[], Task> currentExecutor, CancellationToken cancellationToken) | |||
| { | |||
| var result = await executionState.RunSubmissionsAsync<T>(precedingExecutors, currentExecutor, cancellationToken).ConfigureAwait(continueOnCapturedContext: true); | |||
| var result = await executionState.RunSubmissionsAsync<T>(precedingExecutors, currentExecutor, cancellationToken).ConfigureAwait(continueOnCapturedContext: false); | |||
There was a problem hiding this comment.
This change is not strictly necessary, but I can't imagine why we'd want to continue inline, and there's no comment. It seemed safer to change this to false.
|
No objections. :) |
KevinH-MS
force-pushed
the
EliminateTaskScheduler
branch
from
865e056 to
83f21ab
Compare
KevinH-MS
added a commit
that referenced
this pull request
Jan 5, 2016
Avoid async deadlock in InteractiveHost...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scheduler returned by TaskScheduler.FromCurrentSynchronizationContext
does not allow concurrency (meaning all Tasks within a submission were being
inlined). This would nearly always result in a deadlock if you kicked off a
child Task and attempted to continue within the same submission.
We can instead use the Winforms Dispatcher, which will invoke the parent
Task on the "UI" thread but allow child Tasks to use the ThreadPool.
Fixes #7280