Recognize JoinableTaskSynchronizationContext as a foreground kind #7749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return kind; | ||
| switch (syncConextTypeName) | ||
| { | ||
| case "System.Windows.Threading.DispatcherSynchronizationContext": |
There was a problem hiding this comment.
minor minor nit . I really don't like all your newlines here.
|
Any idea why all the tests are failing? |
| @@ -18,7 +18,7 @@ public static T WaitAndGetResult<T>(this Task<T> task, CancellationToken cancell | |||
| { | |||
| #if DEBUG | |||
| var threadKind = ForegroundThreadDataInfo.CurrentForegroundThreadDataKind; | |||
| if (threadKind != ForegroundThreadDataKind.Wpf && threadKind != ForegroundThreadDataKind.StaUnitTest) | |||
| if (threadKind != ForegroundThreadDataKind.Unknown) | |||
There was a problem hiding this comment.
this should probably be ==. If you change to that and everything passes, then 👍 from me.
There was a problem hiding this comment.
Uh, yeah. That's why you don't write code on New Year's Eve.
This is quick fix to prevent throwing asserts if CPS has changed the foreground SynchronizationContext.
jasonmalinowski
force-pushed
the
allow-joinable-task-context-as-foreground-thread
branch
from
1c0259c to
3ae6474
Compare
|
👍 Thanks! |
|
I'll be looking into the failed mac build. Link to failed build. But in the meantime, |
jasonmalinowski
added a commit
that referenced
this pull request
Jan 5, 2016
…text-as-foreground-thread Recognize JoinableTaskSynchronizationContext as a foreground kind
jasonmalinowski
deleted the
allow-joinable-task-context-as-foreground-thread
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quick fix to prevent throwing asserts if CPS has changed the foreground SynchronizationContext.
Looking at this, I suspect we could probably delete half of our foreground logic with something simpler,
but this unblocks others for now.
Review: @dotnet/roslyn-ide