Use /publicsign instead of FakeSign #7747
Conversation
The compiler now supports publicsign so FakeSign isn't necessary. However, since we're not using the toolset compiler on *nix we can't using the PublicSign property. In the meantime we can pass publicsign in a response file.
Brings in a new toolset compiler that supports publicsign in VB and updates the ci bootstrap to use the bootstrap build task, which provides bootstrap support for the <PublicSign> property.
|
Forgot to update the nuget package. |
|
test prtest/win/dbg/unit64 please |
| built against the xplat MSBuild references so it can't be loaded properly. Providing | ||
| a response file works around the problem by directly adding the public sign argument | ||
| to all unix compilations. This shouldn't present a problem as it's impossible to | ||
| fully sign on unix at the moment anyway --> |
There was a problem hiding this comment.
Where are the bugs tracking these issues? Seems like there are two items to track here:
- Removing this work around on unix.
- Removing the MSBuild limitation that prevents us from using the
<PublicSign>property.
The latter is particularly interesting because it will presumably affect other items like determinism.
There was a problem hiding this comment.
Yeah, this is kind of nasty. I've filed #7756 to track removing this and I'll add a mention of the bug number in the comment.
There are some underlying infrastructrue issues here. First, it appears the MSBuild on Mono eagerly loads tasks listed in Microsoft.Common.tasks. That means that the default task is loaded before we have a chance to redirect it to anywhere else.
But even if that were fixed (which would be difficult, I think, because I don't think the MSBuild version for Mono is getting any updates) there would still be another issue -- our build task is currently built against the Windows desktop MSBuild references. Theoretically, we could dig through the Mono MSBuild NuGet package, find the references, and build a third build task against those references.
I think that's getting a bit ridiculous though -- we already have a build task built against the CoreCLR MSBuild references that's actively being developed. We should instead start moving forward to using that. I've filed bug #7755 for that.
There was a problem hiding this comment.
I think this might be related a bug I filed years ago... I have given up on supporting Mono due to them being lazy monkeys (not offensive, but english for mono) for not fixing non-commercial (read Xamarin) bugs...
There was a problem hiding this comment.
In case of a reference: https://bugzilla.xamarin.com/show_bug.cgi?id=11199
|
👍 |
Use /publicsign instead of FakeSign
Replace usage of FakeSign with /publicsign in Roslyn.
@dotnet/roslyn-compiler @dotnet/roslyn-infrastructure @jaredpar