Account for presence of inapplicable extension methods of the same viability when binding arguments for error recovery in presence of single instance method candidate. #7740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test prtest/win/dbg/unit32 please |
|
LGTM. The added complexity to the internal APIs is unfortunate, but I don't see a better way. |
| @@ -676,6 +678,7 @@ private static void CheckRestrictedTypeReceiver(BoundExpression expression, Comp | |||
| /// <param name="methodGroup">Method group if the invocation represents a potentially overloaded member.</param> | |||
| /// <param name="delegateTypeOpt">Delegate type if method group represents a delegate.</param> | |||
| /// <param name="diagnostics">Diagnostics.</param> | |||
| /// <param name="extensionMethodsOfSameViabilityAreAvailable"/> | |||
…ability when binding arguments for error recovery in presence of single instance method candidate. Fixes dotnet#5128.
|
@jaredpar Comments were added/adjusted per your feedback. |
|
@dotnet/roslyn-compiler Please review, need a second sign off. |
|
LGTM |
AlekseyTs
added a commit
that referenced
this pull request
Jan 6, 2016
Account for presence of inapplicable extension methods of the same viability when binding arguments for error recovery in presence of single instance method candidate.
20 tasks
gafter
added a commit
to gafter/roslyn
that referenced
this pull request
Jun 20, 2016
thereby reducing coupling between internal compiler APIs. See also dotnet#7740 dotnet#5128, where the vestigal APIs were introduced. This also has the effect of removing unbound lambdas from the bound trees, replacing them with the "best" binding for error recovery. This makes the semantic model insensitive to any further trial bindings (i.e. mutation of the unbound lambda cache).
gafter
added a commit
that referenced
this pull request
Jun 22, 2016
We attempt to bind lambda args against every applicable delegate type that could be a matching parameter, and then select the "best" for error recovery. This also has the effect of removing unbound lambdas from the bound trees, replacing them with the "best" binding for error recovery. This makes the semantic model insensitive to any further trial bindings (i.e. mutation of the unbound lambda cache). Fixes #12063, #11979, #11901 Remove vestigal "extensionMethodsOfSameViabilityAreAvailable" thereby reducing coupling between internal compiler APIs. See also #7740 #5128, where the vestigal APIs were introduced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5128.
@dotnet/roslyn-compiler Please review.