CodeGenerator.EmitStackAlloc - Avoid capturing blob array #76660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
dotnet-policy-service
bot
added
the
Community
333fred
reviewed
Jan 7, 2025
| @@ -45,7 +45,11 @@ private void EmitStackAlloc(TypeSymbol type, BoundArrayInitialization? inits, Bo | |||
| var sizeInBytes = elementType.EnumUnderlyingTypeOrSelf().SpecialType.SizeInBytes(); | |||
|
|
|||
| ImmutableArray<byte> data = GetRawData(initExprs); | |||
| #if NET8_0_OR_GREATER | |||
| if (!data.AsSpan().ContainsAnyExcept(data[0])) | |||
There was a problem hiding this comment.
We don't generally have a problem with conditional code, but we usually want to have a good reason to have it; do you have benchmarks or other data indicating this capture is a problem?
AlekseyTs
reviewed
Jan 8, 2025
| @@ -45,7 +45,11 @@ private void EmitStackAlloc(TypeSymbol type, BoundArrayInitialization? inits, Bo | |||
| var sizeInBytes = elementType.EnumUnderlyingTypeOrSelf().SpecialType.SizeInBytes(); | |||
|
|
|||
| ImmutableArray<byte> data = GetRawData(initExprs); | |||
| #if NET8_0_OR_GREATER | |||
| if (!data.AsSpan().ContainsAnyExcept(data[0])) | |||
There was a problem hiding this comment.
In fact we already have the overload in ImmutableArrayExtensions:
public static bool All<T, TArg>(this ImmutableArray<T> array, Func<T, TArg, bool> predicate, TArg arg)
|
Done with review pass (commit 1) |
jjonescz
approved these changes
Jan 9, 2025
src/Compilers/CSharp/Portable/CodeGen/EmitStackAllocInitializer.cs
Outdated
Show resolved
Hide resolved
…r.cs Co-authored-by: Jan Jones <[email protected]>
|
@alrz Thanks for the contribution |
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jan 14, 2025
* upstream/main: (368 commits) Cleanup tests Add test Add test Add test Fix issue parsing regex category Properly simplify pattern when converting to pattern matching update publishdata after VS 17.13 snap Simplify Docs Do not lift type parameters in extract method declared within the selected region Fix ExtractMethod in VB elseif blocks Rework our Helix Process (dotnet#76703) Stash and restore original culture in CultureNormalizer (dotnet#76713) PR comments Adding checks for mutable structs. Add additional tests for string escape sequences CodeGenerator.EmitStackAlloc - Avoid capturing blob array (dotnet#76660) Update comments and exception type for LSP stdio configuration based on review feedback Fix race generating Microsoft.Managed.Core.CurrentVersions.targets (dotnet#76701) Update FileDownloader.cs ...
This was referenced Jan 14, 2025
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if conditional code on dotnet version is acceptable as this API is only available in 8.0+.