Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to control if unused members shoudl be faded out. #76520

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #76396

Looks like:

image

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner December 19, 2024 18:26
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 19, 2024
Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit surprised we went with this option instead of just reusing the option we already have, but either way gets the job done. A couple issues found.

@@ -1621,7 +1621,7 @@ parseOptions:=Nothing,
compilationOptions:=Nothing,
options:=Nothing,
"IDE0051",
DiagnosticSeverity.Info,
DiagnosticSeverity.Hidden,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 The default severity for this should probably not change

@CyrusNajmabadi CyrusNajmabadi merged commit fbdd94c into dotnet:main Dec 19, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 19, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the memberFading branch December 19, 2024 22:12
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Needs UX Triage untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No ability to disable fading for unused private methods analyzer
4 participants