Remove sync over async blocking in workspace #76491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
JoeRobich
approved these changes
Dec 18, 2024
| @@ -456,17 +462,18 @@ public async Task<IEnumerable<TextChange>> GetTextChangesAsync(Document oldDocum | |||
| // get changes by diffing the trees | |||
| if (this.SupportsSyntaxTree) | |||
| { | |||
| var tree = (await this.GetSyntaxTreeAsync(cancellationToken).ConfigureAwait(false))!; | |||
| var oldTree = await oldDocument.GetSyntaxTreeAsync(cancellationToken).ConfigureAwait(false); | |||
| var tree = this.GetSyntaxTreeSynchronously(cancellationToken); | |||
There was a problem hiding this comment.
@CyrusNajmabadi Not sure I understand this bit unless you had some other data for it -- GetSyntaxTreeSynchronously will block threads if we have to read the tree from disk. That's considered acceptable in the UI thread case (since the thread is blocked either way), but this could create problems if we we're calling it on a bunch of threads all at once since we might block up the thread pool.
This was referenced Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.