Slightly reduce allocations in SymbolCompletionItem.AddSymbolInfo #76418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code creates a string from the SymbolKind enum and was showing up as 0.2% of allocations in the typing scenario in the csharp editing speedometer test. Instead, mimic what the core runtime does in the Number class by keeping a small cache mapping int => string that is lazily populated.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
|
||
| [MethodImpl(MethodImplOptions.NoInlining)] // keep rare usage out of fast path | ||
| static string CreateAndCacheString(int value) | ||
| => s_smallNumberCache[value] = value.ToString(); |
There was a problem hiding this comment.
already an issue, but perhaps make this ordinal? seems odd that this would be impated by locale
There was a problem hiding this comment.
I don't think the int32.ToString no arg implementation of this method is locale sensitive.
src/Features/Core/Portable/Completion/Providers/SmallNumberFormatter.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Dec 13, 2024
CyrusNajmabadi
approved these changes
Dec 13, 2024
This was referenced Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code creates a string from the SymbolKind enum and was showing up as 0.2% of allocations in the typing scenario in the csharp editing speedometer test.
Instead, mimic what the core runtime does in the Number class by keeping a small cache mapping int => string that is lazily populated.
I did check to see whether other places in the profile implicating FormatInt32 were candidates for changing to this, and neither of the two found locations fit well. The call from SymbolCompletionItem.CreateWorker has values that are too large and varied to consider caching, and the usage in SymbolKeyWriter.WriteIntegerRaw_DoNotCallDirectly would require the helper class to be available at the CodeStyle layer.
*** Allocations targeted with this PR ***
