Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle trivial case in 'use null propagation' #76321

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Handle trivial case in 'use null propagation' #76321

merged 1 commit into from
Dec 7, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #66141

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner December 7, 2024 08:49
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 7, 2024
@build-analysis build-analysis bot mentioned this pull request Dec 7, 2024
Open
3 tasks
ToddGrun
ToddGrun reviewed Dec 7, 2024
View reviewed changes
src/Analyzers/Core/Analyzers/UseNullPropagation/AbstractUseNullPropagationDiagnosticAnalyzer.cs
public static bool IsSystemNullableValueProperty([NotNullWhen(true)] ISymbol? symbol)
=> symbol is
{
Name: nameof(Nullable<int>.Value),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name: nameof(Nullable.Value),

Does the SpecialType check prevent the need for the namespace checks?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

ToddGrun
ToddGrun approved these changes Dec 7, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge (squash) December 7, 2024 17:42
@CyrusNajmabadi CyrusNajmabadi merged commit 6bb81dc into dotnet:main Dec 7, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 7, 2024
This was referenced Dec 12, 2024
Closed
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

@JoeRobich JoeRobich Awaiting requested review from JoeRobich

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
17.13 P3
Development

Successfully merging this pull request may close these issues.

IDE0031: Null check can be simplified. Use null propagation does nothing.
3 participants
@CyrusNajmabadi @ToddGrun @dibarbet