Fix broken strings in Unified Setting page #76289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
Cosifne
commented
Dec 5, 2024
| @@ -49,7 +49,7 @@ public static string Option_Never_add_new_line_on_enter | |||
| => ServicesVSResources.Never_add_new_line_on_enter; | |||
|
|
|||
| public static string Option_Only_add_new_line_on_enter_with_whole_word | |||
| => ServicesVSResources.Only_add_new_line_on_enter_after_end_of_fully_typed_word; | |||
| => ServicesVSResources._Only_add_new_line_on_enter_after_end_of_fully_typed_word; | |||
There was a problem hiding this comment.
This is for the accelerator _ we need that in our page, not needed in Unified Settings page.
dibarbet
approved these changes
Dec 6, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@dotnet-policy-service rerun |
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clearly strings are going to be broken if this is merged.
dfc660c#diff-a16de2a58a10f14a7fc8512f47bbd467869339a6135046bb0274d2fce1151f93R1901
This PR brings back to track.
Current:
After:
This should be covered by unit test. I am preparing it in https://github.com/Cosifne/roslyn/tree/dev/shech/UnifiedSettingsAdvPage, will cover these strings will that is ready