Update SystemTextJsonVersion #76273
Update SystemTextJsonVersion #76273
Conversation
fix nuget audit
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
dotnet-policy-service
bot
added
the
Community
| @@ -61,7 +61,7 @@ | |||
| <SystemSecurityPermissionsVersion>8.0.0</SystemSecurityPermissionsVersion> | |||
| <!-- Note: When updating SystemTextJsonVersion ensure that the version is no higher than what is used by MSBuild. --> | |||
There was a problem hiding this comment.
msbuild already using the 8.0.5 version
msbuild main is using STJ 8.0.5, but isn't this comment trying to say that the msbuild which roslyn is referencing should be using STJ 8.0.5? (and I'm not sure if that's the case)
There was a problem hiding this comment.
Nice catch, I'm not sure either.
While from the NuGet package dependencies, seems there's no dependency for Microsoft.Build in the package I referenced Microsoft.CodeAnalysis.CSharp.Features
Think maybe it's related to the MSBuild version in VS/VSCode, and from the latest Microsoft.Build version released last month, it's also using the 8.0.5 System.Text.Json`
There was a problem hiding this comment.
If I recall, it has to do with VS insertions. At one point we tried to insert with a version higher than MSBuild and it caused NGen errors. We should be fine to take this change.
fix vulnerability nuget audit
msbuild already using the
8.0.5version