Update filenames in file banners when moving a type to a new file. #76270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Dec 4, 2024
| @@ -125,38 +119,6 @@ private static ImmutableArray<SyntaxTrivia> GetBannerFromEquivalenceKey(string e | |||
| return bannerService.GetFileBanner(token); | |||
| } | |||
|
|
|||
| private Task<Document> AddBannerAsync( | |||
There was a problem hiding this comment.
moved to a common location so it can be used in MoveType.
ToddGrun
reviewed
Dec 4, 2024
| ImmutableArray<SyntaxTrivia> banner, | ||
| Func<SyntaxTrivia, string, SyntaxTrivia> createTrivia) | ||
| { | ||
| var sourceName = IOUtilities.PerformIO(() => Path.GetFileName(sourceDocument.FilePath)); |
There was a problem hiding this comment.
I'll do a pass later to address these
ToddGrun
reviewed
Dec 4, 2024
| @@ -146,7 +145,10 @@ private async Task<Document> AddNewDocumentWithSingleTypeDeclarationAsync(Docume | |||
| // get the updated document, give it the minimal set of imports that the type | |||
| // inside it needs. | |||
There was a problem hiding this comment.
this comment confuses me, it doesn't look like imports are handled in this method
There was a problem hiding this comment.
Yeah. Seems incorrect. Was already like that, so I'll move to another pr in this space to cleanup.
ToddGrun
reviewed
Dec 4, 2024
|
|
||
| /// <summary> | ||
| /// Looks at <paramref name="banner"/> to see if it contains the name of <paramref name="sourceDocument"/> | ||
| /// in it. If so, those names will be replaced with <paramref name="destinationFilePath"/>. |
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74703