Dictionary expressions: initial binding and lowering support #76257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
dotnet-policy-service
bot
added
the
Needs API Review
cston
force-pushed
the
dictionary-binding
branch
from
5da632a to
74a425d
Compare
cston
force-pushed
the
dictionary-binding
branch
from
6b7dd35 to
767c1c9
Compare
cston
force-pushed
the
dictionary-binding
branch
from
1fba2ac to
006323a
Compare
jcouv
reviewed
Dec 12, 2024
jcouv
reviewed
Dec 12, 2024
src/Compilers/CSharp/Portable/Binder/Semantics/Conversions/ConversionsBase.cs
Show resolved
Hide resolved
jcouv
reviewed
Dec 12, 2024
src/Compilers/CSharp/Portable/Binder/Semantics/Conversions/Conversions.cs
Show resolved
Hide resolved
jcouv
reviewed
Dec 12, 2024
src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_CollectionExpression.cs
Show resolved
Hide resolved
jcouv
reviewed
Dec 12, 2024
src/Compilers/CSharp/Portable/Binder/Semantics/Conversions/Conversions.cs
Show resolved
Hide resolved
jcouv
reviewed
Dec 12, 2024
jcouv
reviewed
Dec 12, 2024
src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_CollectionExpression.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Dec 12, 2024
src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_CollectionExpression.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Dec 12, 2024
src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_CollectionExpression.cs
Show resolved
Hide resolved
jcouv
reviewed
Dec 12, 2024
src/Compilers/CSharp/Test/Emit3/Semantics/DictionaryExpressionTests.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Dec 12, 2024
jcouv
reviewed
Dec 12, 2024
src/Compilers/CSharp/Test/Emit3/Semantics/DictionaryExpressionTests.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Dec 12, 2024
jcouv
reviewed
Dec 12, 2024
jcouv
removed
Needs API Review
333fred
reviewed
Dec 17, 2024
| @@ -235,6 +259,8 @@ internal Conversion GetCollectionExpressionSpreadElementConversion( | |||
| { | |||
| return Conversion.NoConversion; | |||
| } | |||
| // This should be conversion from type rather than conversion | |||
There was a problem hiding this comment.
Using conversion from expression rather than conversion from type is a bug. The one case that I'm aware of where this is observable is when the spread element type is dynamic. Unfortunately, fixing this would be a breaking change for that case.
For instance, the following is currently allowed but would be an error when using conversion from type:
dynamic[] x = [1, 2, 3];
int[] y = [..x];I could log a bug and reference that here if that seems useful.
There was a problem hiding this comment.
I've updated the comment to include the example.
src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_CollectionExpression.cs
Show resolved
Hide resolved
| { | ||
| string source = """ | ||
| using System.Collections.Generic; | ||
| IDictionary<int, string> d = [1:"one"]; |
There was a problem hiding this comment.
Consider testing var x = [1:"one"]; as well. #Resolved
Comment on lines
+131
to
+136
| // (12,16): error CS9215: Collection expression type 'Dictionary<int, string>' must have an instance or extension method 'Add' that can be called with a single argument. | ||
| // return [1:"one", x, ..y]; | ||
| Diagnostic(ErrorCode.ERR_CollectionExpressionMissingAdd, @"[1:""one"", x, ..y]").WithArguments("System.Collections.Generic.Dictionary<int, string>").WithLocation(12, 16), | ||
| // (12,17): error CS9268: Collection expression type 'Dictionary<int, string>' does not support key-value pair elements. | ||
| // return [1:"one", x, ..y]; | ||
| Diagnostic(ErrorCode.ERR_CollectionExpressionKeyValuePairNotSupported, @"1:""one""").WithArguments("System.Collections.Generic.Dictionary<int, string>").WithLocation(12, 17)); |
There was a problem hiding this comment.
I do not understand why there are errors here. Am I missing something about the feature? I would expect all of these to be fine. #Resolved
There was a problem hiding this comment.
This PR implements support for dictionary interface target types only. It does not include support for concrete types such as Dictionary<K, V>.
| } | ||
|
|
||
| [Fact] | ||
| public void EvaluationOrder_01() |
There was a problem hiding this comment.
Consider some examples with complex sub-flow (like ternaries or switch expressions) in the key and value positions. #Resolved
333fred
approved these changes
Dec 18, 2024
cston
merged commit 5439dd5
into
dotnet:features/dictionary-expressions
24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binding and lowering for
IDictionary<K, V>andIReadOnlyDictionary<K, V>target types.See proposals/dictionary-expressions.md
Relates to test plan #76310