Update find-refs to find references to Dispose in a using-statement #76221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
ToddGrun
reviewed
Dec 3, 2024
| @@ -90,7 +90,7 @@ private static SyntaxTreeIndex CreateIndex( | |||
|
|
|||
| containsForEachStatement = containsForEachStatement || syntaxFacts.IsForEachStatement(node); | |||
| containsLockStatement = containsLockStatement || syntaxFacts.IsLockStatement(node); | |||
| containsUsingStatement = containsUsingStatement || syntaxFacts.IsUsingStatement(node); | |||
| containsUsingStatement = containsUsingStatement || syntaxFacts.IsUsingStatement(node) || syntaxFacts.IsUsingLocalDeclarationStatement(node); | |||
There was a problem hiding this comment.
To clarify for me, this is tracking both "using namespace" and "using var foo = IDisposable" statements, right?
Yes.
Other than the name being the same, why are they grouped together?
Because this is for FindRefs, which only cares about tthis info just to say "should i look for Dispose references here?". And for FindRefs, it doesn't care about which of the two cases it is.
I could do this as two different bools, but the consumption side would then have to check for both. So i just collapse here to one bool since htat's all we need.
ToddGrun
approved these changes
Dec 3, 2024
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34107