Don't place 'async' after 'partial' modifier #76168
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| @@ -177,7 +180,21 @@ private static bool IsIEnumerator(ITypeSymbol returnType, KnownTaskTypes knownTy | |||
| private static (SyntaxTokenList newModifiers, TypeSyntax newReturnType) AddAsyncModifierWithCorrectedTrivia(SyntaxTokenList modifiers, TypeSyntax returnType) | |||
| { | |||
| if (modifiers.Any()) | |||
| return (modifiers.Add(s_asyncKeywordWithSpace), returnType); | |||
| { | |||
| // 'partial' modifier must say at the end of the modifiers arrays. | |||
There was a problem hiding this comment.
I think await completion that I implemented may have the exact same bug. The bug is more critical for IntelliSense I think.
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks @Youssef1313 . I'm going to handle in a followup pr.
| return (modifiers.Add(s_asyncKeywordWithSpace), returnType); | ||
| { | ||
| // 'partial' modifier must say at the end of the modifiers arrays. | ||
| var partialModifier = modifiers.FirstOrDefault(static m => m.IsKind(SyntaxKind.PartialKeyword)); |
There was a problem hiding this comment.
What about this, it's internal, but I thought it would be accessible? Works the way you have it, and I know the lists are small, but it seems weird to always search to find it.
There was a problem hiding this comment.
What about this, it's internal,
Nope. That's in compiler layer. We don't have IVT to them. We could make an extension at workspace layer, and update to that. i empower you :)
There was a problem hiding this comment.
Isn't it already exposed as an extension method by the compiler itself?
| @@ -177,7 +180,21 @@ private static bool IsIEnumerator(ITypeSymbol returnType, KnownTaskTypes knownTy | |||
| private static (SyntaxTokenList newModifiers, TypeSyntax newReturnType) AddAsyncModifierWithCorrectedTrivia(SyntaxTokenList modifiers, TypeSyntax returnType) | |||
| { | |||
| if (modifiers.Any()) | |||
| return (modifiers.Add(s_asyncKeywordWithSpace), returnType); | |||
| { | |||
| // 'partial' modifier must say at the end of the modifiers arrays. | |||
|
@genlu ptal. |
Fixes #63404