Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not offer to remove the primary field from an inline array #76052

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #69143

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 23, 2024 03:57
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 23, 2024
=> compilation.GetTypeByMetadataName(typeof(StructLayoutAttribute).FullName!);

public static INamedTypeSymbol? InlineArrayAttributeType(this Compilation compilation)
=> compilation.GetTypeByMetadataName("System.Runtime.CompilerServices.InlineArrayAttribute");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InlineArrayAttribute

can typeof not be used here too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. this compiles against sdks that doesn't have this type itself.

Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 1ab631d into dotnet:main Nov 25, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the inlineArray branch November 25, 2024 22:18
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 25, 2024
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress IDE0044/IDE0051 for [InlineArray] types
3 participants