Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix explicit generation of static conversion methods in interfaces #76022

Merged
merged 3 commits into from
Nov 23, 2024
Merged

Fix explicit generation of static conversion methods in interfaces #76022

merged 3 commits into from
Nov 23, 2024

Conversation

CyrusNajmabadi
Copy link
Member

Fixes #61263

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 22, 2024 02:34
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 22, 2024
@ToddGrun
Copy link
Contributor

looks good, afaict

ToddGrun
ToddGrun approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit 36754e8 into dotnet:main Nov 23, 2024
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the implInterfaceExplicit branch November 23, 2024 00:25
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 23, 2024
@dotnet-bot dotnet-bot mentioned this pull request Nov 25, 2024
Closed
@jjonescz jjonescz modified the milestones: Next, 17.13 P2 Nov 25, 2024
@dotnet-bot dotnet-bot mentioned this pull request Nov 26, 2024
Closed
@dotnet-bot dotnet-bot mentioned this pull request Dec 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
17.13 P2
Development

Successfully merging this pull request may close these issues.

"Implement interface explicitly" fixer implements conversion operators implicitly
3 participants
@CyrusNajmabadi @ToddGrun @jjonescz