Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix symbol display for backing fields #76000

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Fix symbol display for backing fields #76000

merged 5 commits into from
Nov 22, 2024

Conversation

RikkiGibson
Copy link
Contributor

Closes #75529

@RikkiGibson RikkiGibson requested review from a team as code owners November 21, 2024 00:08
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 21, 2024
@RikkiGibson RikkiGibson marked this pull request as draft November 21, 2024 03:40
@AlekseyTs
Copy link
Contributor

Done with review pass (commit 1)

@RikkiGibson RikkiGibson marked this pull request as ready for review November 22, 2024 06:00
@AlekseyTs
Copy link
Contributor

Done with review pass (commit 4)

AlekseyTs
AlekseyTs approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 5)

@RikkiGibson RikkiGibson merged commit 2c4b274 into dotnet:main Nov 22, 2024
28 checks passed
@RikkiGibson RikkiGibson deleted the field-symboldisplay branch November 22, 2024 19:23
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 22, 2024
@dotnet-bot dotnet-bot mentioned this pull request Nov 25, 2024
Closed
@jjonescz jjonescz modified the milestones: Next, 17.13 P2 Nov 25, 2024
@dotnet-bot dotnet-bot mentioned this pull request Nov 26, 2024
Closed
@dotnet-bot dotnet-bot mentioned this pull request Dec 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@cston cston cston approved these changes

Assignees
No one assigned
Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.13 P2
Development

Successfully merging this pull request may close these issues.

Quick info on field exposes generated member name, unlike on accessors
4 participants
@RikkiGibson @AlekseyTs @cston @jjonescz