Use more specific checks for skipping work for unused usings #74807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures AnalyzeSemanticModel only performs analysis when unused imports are being reported. Previously, this method would run when the only enabled diagnostic was 'EnableGenerateDocumentationFile', even though that diagnostic is unrelated to the work performed in AnalyzeSemanticModel. Discovered during investigation of dotnet#74761.
dotnet-issue-labeler
bot
added
Area-Analyzers
untriaged
|
This seems fine to me. But my preference is still that we take this and shutoff the other analyzer. Code style on generated code doesn't make sense to me. And i cannot reconcile that we have this particular style analyzer on, while not having any other analyzers on (especially ones that related to unnecessary code) :) |
src/Analyzers/Core/Analyzers/AbstractBuiltInCodeStyleDiagnosticAnalyzer_Core.cs
Outdated
Show resolved
Hide resolved
...ore/Analyzers/RemoveUnnecessaryImports/AbstractRemoveUnnecessaryImportsDiagnosticAnalyzer.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures AnalyzeSemanticModel only performs analysis when unused imports are being reported. Previously, this method would run when the only enabled diagnostic was 'EnableGenerateDocumentationFile', even though that diagnostic is unrelated to the work performed in AnalyzeSemanticModel.
Discovered during investigation of #74761.