-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not run 'remove unnecessary imports' on generated code #74762
Merged
CyrusNajmabadi
merged 13 commits into
dotnet:main
from
CyrusNajmabadi:unnecessaryImportGeneratedCode
Nov 14, 2024
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
eea79f8
Do not run 'remove unnecessary imports' on generated code
CyrusNajmabadi 6b5e43a
Merge branch 'main' into unnecessaryImportGeneratedCode
CyrusNajmabadi 6f1009c
Merge branch 'main' into unnecessaryImportGeneratedCode
CyrusNajmabadi 1a82dc9
Merge branch 'main' into unnecessaryImportGeneratedCode
CyrusNajmabadi 1a1f3ca
Merge branch 'main' into unnecessaryImportGeneratedCode
CyrusNajmabadi 61b3d3a
Merge branch 'main' into unnecessaryImportGeneratedCode
CyrusNajmabadi c825d55
Merge branch 'main' into unnecessaryImportGeneratedCode
CyrusNajmabadi 44fa212
Merge remote-tracking branch 'upstream/main' into unnecessaryImportGe…
CyrusNajmabadi 78759a2
Switch to primary constructor
CyrusNajmabadi 8abea8b
Switch to raw strings
CyrusNajmabadi 6121e9b
Fix test
CyrusNajmabadi 3afc07b
Fix test
CyrusNajmabadi e541697
Merge remote-tracking branch 'upstream/main' into unnecessaryImportGe…
CyrusNajmabadi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -71,8 +71,6 @@ private static ImmutableArray<DiagnosticDescriptor> GetDescriptors(LocalizableSt | |
protected abstract bool IsRegularCommentOrDocComment(SyntaxTrivia trivia); | ||
protected abstract IUnnecessaryImportsProvider<TSyntaxNode> UnnecessaryImportsProvider { get; } | ||
|
||
protected override GeneratedCodeAnalysisFlags GeneratedCodeAnalysisFlags => GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That way I think |
||
|
||
protected abstract SyntaxToken? TryGetLastToken(SyntaxNode node); | ||
|
||
protected override void InitializeWorker(AnalysisContext context) | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a
[WorkItem]
to the test to clarify, why no diagnostics there are expected