Add refactoring to convert a primary-constructor-parameter to a normal constructor. #70399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Oct 16, 2023
| var parameterLeadingWhitespace = GetLeadingWhitespace(p); | ||
| if (parameterLeadingWhitespace.EndsWith(indentation)) | ||
| var elementLeadingWhitespace = GetLeadingWhitespace(p); | ||
| if (elementLeadingWhitespace.EndsWith(indentation)) |
There was a problem hiding this comment.
renamed to be more accurate. this helper was used for more htan just parameters.
CyrusNajmabadi
commented
Oct 16, 2023
| var containgTypeAnalyzer = TryGetOrCreateAnalyzer(containingType); | ||
| RegisterFieldOrPropertyAnalysisIfNecessary(containgTypeAnalyzer); | ||
| var containingTypeAnalyzer = TryGetOrCreateAnalyzer(containingType); | ||
| RegisterFieldOrPropertyAnalysisIfNecessary(containingTypeAnalyzer); |
CyrusNajmabadi
commented
Oct 16, 2023
| CodeActionOptionsProvider optionsProvider, | ||
| CancellationToken cancellationToken) | ||
| { | ||
| var compilation = await document.Project.GetCompilationAsync(cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
tried to doc this method to help make every rewrite step clear. let me know if more clarity is needed.
|
@genlu ptal. |
akhera99
approved these changes
Oct 19, 2023
Cosifne
reviewed
Oct 19, 2023
...vertPrimaryToRegularConstructor/ConvertPrimaryToRegularConstructorCodeRefactoringProvider.cs
Show resolved
Hide resolved
Cosifne
reviewed
Oct 19, 2023
...vertPrimaryToRegularConstructor/ConvertPrimaryToRegularConstructorCodeRefactoringProvider.cs
Show resolved
Hide resolved
Cosifne
reviewed
Oct 19, 2023
...vertPrimaryToRegularConstructor/ConvertPrimaryToRegularConstructorCodeRefactoringProvider.cs
Show resolved
Hide resolved
Cosifne
reviewed
Oct 19, 2023
...vertPrimaryToRegularConstructor/ConvertPrimaryToRegularConstructorCodeRefactoringProvider.cs
Show resolved
Hide resolved
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have an feature to do the reverse. This now lets you switch back easily.
Note: we do want this as primary constructors have limitations (for example, being able to add argument checks). So if a person starts with a primary constructor and wants to easily move off of it to make such changes, we don't want that to be an arduous process.