Pack our language server in a separate package for each platform #69786
Conversation
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
jasonmalinowski
force-pushed
the
create-separate-packages-for-each-rid
branch
from
02d6774 to
27928f8
Compare
...ageServer/Microsoft.CodeAnalysis.LanguageServer/Microsoft.CodeAnalysis.LanguageServer.csproj
Show resolved
Hide resolved
jasonmalinowski
force-pushed
the
create-separate-packages-for-each-rid
branch
2 times, most recently
from
352f525 to
5e30ea8
Compare
Our LanguageServer package is a special package where we are bundling ready-to-run images that are then consumed by our C# extension build. We we previously building all platforms into one single NuGet package, but we are getting dangerously close to the 500MB limit that is enforced by Azure DevOps for the total size of a package. This splits our package into 10 packages, one for each platform (and our "neutral" package).
jasonmalinowski
force-pushed
the
create-separate-packages-for-each-rid
branch
from
5e30ea8 to
624b70e
Compare
| @@ -47,6 +47,16 @@ | |||
| "Microsoft.VisualStudio.IntegrationTest.Utilities": "vs-impl", | |||
| "Microsoft.VisualStudio.LanguageServices.DevKit": "npm", | |||
| "Microsoft.CodeAnalysis.LanguageServer": "vs-impl", | |||
There was a problem hiding this comment.
We are leaving this old entry, because the version of this file from the main branch is the one always used for publishing. So if any servicing branch did a signed build, it'd look for this entry or otherwise it'll fail.
| @@ -5,7 +5,6 @@ | |||
| <OutputType>Library</OutputType> | |||
| <TargetFramework>net7.0</TargetFramework> | |||
| <Nullable>enable</Nullable> | |||
| <IsPackable>true</IsPackable> | |||
There was a problem hiding this comment.
We were creating a NuGet package for this project, but we don't actually need it. We make an NPM package, but we can turn this off and it still works. This had to be fixed or otherwise when building this package, it no longer knows which of the LanguageServer packages to reference.
| @@ -19,7 +19,7 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <ProjectReference Include="..\..\..\Features\LanguageServer\Microsoft.CodeAnalysis.LanguageServer\Microsoft.CodeAnalysis.LanguageServer.csproj" /> | |||
There was a problem hiding this comment.
The CompilerDeveloperSDK package was shipping a NuGet reference to the LanguageServer package; this was silly since it wouldn't have shipped any useful binaries, but did carry along a half a gigabyte of content files.
ghost
added this to the 
Our LanguageServer package is a special package where we are bundling ready-to-run images that are then consumed by our C# extension build. We we previously building all platforms into one single NuGet package, but we are getting dangerously close to the 500MB limit that is enforced by Azure DevOps for the total size of a package. This splits our package into 10 packages, one for each platform (and our "neutral" package).