Work around restore issue #69710
Merged
Work around restore issue #69710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
Running `Build.cmd -pack -restore` on most machines is leading to the following error: > \NuGet.RestoreEx.targets(19,5): error : The filename or extension is too long This seems to be caused by an excessively long command line being passed to a tool within the NuGetRestoreEx task. Temporarily working around this by disabling static graph on this restore operation. NuGet/Home#12843
dibarbet
approved these changes
Aug 24, 2023
ryzngard
approved these changes
Aug 24, 2023
|
how could this issue be specific to static graph restore.. also, does this mean the command line we pass to this tool has been growing and we recently hit a threshold? and the paths in the CI environments are shorter than local paths tend to be, so we weren't seeing a failure there? what a bug, man. |
jjonescz
approved these changes
Aug 25, 2023
| @@ -127,7 +127,7 @@ | |||
| We have to run restore first with the PublishReadyToRun flag set to true to ensure that the correct crossgen packages get restored. | |||
| See https://github.com/dotnet/sdk/issues/20701 | |||
| --> | |||
| <MSBuild Projects="$(MSBuildProjectFullPath)" Targets="Restore" Properties="RestoreWithR2R=true" /> | |||
| <MSBuild Projects="$(MSBuildProjectFullPath)" Targets="Restore" Properties="RestoreWithR2R=true;RestoreUseStaticGraphEvaluation=false" /> | |||
There was a problem hiding this comment.
Should we file a tracking issue to revert this?
There was a problem hiding this comment.
If nothing else, we should have a comment explaining it.
This was referenced Aug 25, 2023
Closed
Closed
Closed
|
Going to merge this as soon as the integration CI passes (Tomas just hit this as well). I'll send a followup to add a comment as soon as this goes in to avoid another re-run of CI. |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
Build.cmd -pack -restoreon most machines is leading to the following error:This seems to be caused by an excessively long command line being passed to a tool within the NuGetRestoreEx task. Temporarily working around this by disabling static graph on this restore operation.
NuGet/Home#12843